Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10706 メール送信テスト時に宛先が空のときは送れないようにする #10719

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

tar-bin
Copy link
Contributor

@tar-bin tar-bin commented Apr 26, 2023

What

#10706 の問題を修正しました。

  • プレースホルダーを [email protected] に修正
  • 管理者メールアドレスをプレースホルダーではなくデフォルト値に変更
  • 値が空の時に送信できない(OKボタンを押せない)ように minLength 1 を設定

Why

#10706 の時に送信エラーと誤認するため

Additional info (optional)

ローカル環境で動作確認済みです。

未入力時の表示
image

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #10719 (8cff1d2) into develop (f3206d0) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #10719   +/-   ##
========================================
  Coverage    76.07%   76.08%           
========================================
  Files          898      898           
  Lines        88717    88742   +25     
  Branches      6259     6263    +4     
========================================
+ Hits         67494    67515   +21     
- Misses       21223    21227    +4     

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit 5124db5 into misskey-dev:develop Apr 27, 2023
@syuilo
Copy link
Member

syuilo commented Apr 27, 2023

👍🏻

@tar-bin tar-bin deleted the fix_10706 branch April 27, 2023 10:50
sasagar pushed a commit to sasagar/misskey that referenced this pull request May 9, 2023
na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants