Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(server): 環境変数MISSKEY_CONFIG_YMLでdefault.ymlを任意のymlに変更可能に #10712

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Apr 25, 2023

What

Misskeyサーバー起動時に環境変数としてMISSKEY_CONFIG_YMLを設定することで、default.ymlから任意のymlへ変更できるようにします。

Why

同じディレクトリ・ビルトファイルで複数のサーバーを建てたい時がある

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Apr 25, 2023
@tamaina tamaina changed the title enhance(server): MISSKEY_CONFIG_YMLでconfigを設定可能に enhance(server): 環境変数MISSKEY_CONFIG_YMLでconfigを設定可能に Apr 25, 2023
@tamaina tamaina changed the title enhance(server): 環境変数MISSKEY_CONFIG_YMLでconfigを設定可能に enhance(server): 環境変数MISSKEY_CONFIG_YMLでdefault.ymlを変更可能に Apr 25, 2023
@tamaina tamaina changed the title enhance(server): 環境変数MISSKEY_CONFIG_YMLでdefault.ymlを変更可能に enhance(server): 環境変数MISSKEY_CONFIG_YMLでdefault.ymlを任意のymlに変更可能に Apr 25, 2023
@tamaina tamaina marked this pull request as ready for review April 25, 2023 06:08
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #10712 (3c23cfe) into develop (f3206d0) will increase coverage by 2.27%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #10712      +/-   ##
===========================================
+ Coverage    76.07%   78.35%   +2.27%     
===========================================
  Files          898      165     -733     
  Lines        88717    20571   -68146     
  Branches      6259      368    -5891     
===========================================
- Hits         67494    16118   -51376     
+ Misses       21223     4453   -16770     

see 733 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina
Copy link
Contributor Author

tamaina commented Apr 25, 2023

とりあえずマージしちゃう(脆弱性ないよね…?)

@tamaina tamaina merged commit b9b9cd0 into develop Apr 25, 2023
@tamaina tamaina deleted the confpath branch April 25, 2023 06:18
@syuilo
Copy link
Member

syuilo commented Apr 25, 2023

👍🏻

sasagar pushed a commit to sasagar/misskey that referenced this pull request May 9, 2023
…skey-dev#10712)

* enhance(server): MISSKEY_CONFIG_YMLでconfigを設定可能に

* update changelog
na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
…skey-dev#10712)

* enhance(server): MISSKEY_CONFIG_YMLでconfigを設定可能に

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants