Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: フォロー中のボタンに重なる「フォロー解除」の文字色を変更 #10672

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

sasagar
Copy link
Contributor

@sasagar sasagar commented Apr 18, 2023

What

フォロー中のユーザープロフィールに表示される「フォロー解除」ボタンについて、
背景色に対して適切な色指定になっていなかった物を修正しました。

背景色は accent であるのに対し、元々は #fff で固定されていることから、組み合わせ上見づらいパターンがあったものを、
accent に対して重なる文字色として用意されて居るであろう fgOnAccent に変更しました。

背景色が accent であるその他のボタンと同じ状態に揃えた格好です。

Why

明るい色を背景にしたテーマを活用した際に文字の視認性が著しく下がり、フォローできたのかどうかがわからなかったため。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #10672 (c3e8e1b) into develop (aa289c9) will increase coverage by 2.88%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #10672      +/-   ##
===========================================
+ Coverage    75.51%   78.39%   +2.88%     
===========================================
  Files          734      165     -569     
  Lines        68517    20555   -47962     
  Branches      5945      368    -5577     
===========================================
- Hits         51739    16114   -35625     
+ Misses       16778     4441   -12337     
Impacted Files Coverage Δ
...ackages/frontend/src/components/MkFollowButton.vue 100.00% <100.00%> (ø)

... and 894 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit b26807b into misskey-dev:develop Apr 18, 2023
@syuilo
Copy link
Member

syuilo commented Apr 18, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants