Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10666 チャンネル検索ですべてのチャンネルの取得/表示ができるようにする #10667

Merged
merged 24 commits into from
May 4, 2023

Conversation

tar-bin
Copy link
Contributor

@tar-bin tar-bin commented Apr 17, 2023

What

  • channels/search APIにてqueryが空の場合は全てのチャンネルを返すようにしました(ページング前提でlimitはあり)
  • チャンネル検索ページでなにも入力せずに検索ボタンを押した場合はすべてのチャンネルを表示するようにしました

Why

#10666 に記載しています。

Additional info (optional)

ローカル環境、およびノベルスキー/もじすきーサーバーにて動作確認済みです。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

tamaina and others added 19 commits February 23, 2023 22:15
Merge pull request #10048 from misskey-dev/develop
Merge pull request #10050 from misskey-dev/develop
* Add dialog to remove follower (#9718)

* update PULL_REQUEST_TEMPLATE

* 起動時にRedisの疎通確認を行う (#9832)

* 起動時にRedisの疎通確認を行う

* check:connectをstart内に移動

---------

Co-authored-by: tamaina <[email protected]>

* Pass `--detectOpenHandles` to Jest (#9895)

Co-authored-by: tamaina <[email protected]>

* enhance(client): MkUrlPreviewの閉じるボタンを見やすく (#9913)

Co-authored-by: tamaina <[email protected]>

* test(backend): restore ap-request tests (#9997)

Co-authored-by: tamaina <[email protected]>

* fix/refaftor(client): MkTime.vueの変更 (#10061)

* fix(client): MkTime.timeにstringでもDateでない値が入った場合、?を表示

* fix(client): MkTimeを改良

* numberを許容

* falsyな値もとる

* 不明

* ありません

* fix

* fix(server): notes/createで、fileIdsと見つかったファイルの数が異なる場合はエラーにする (#9911)

* fix(server): notes/createで、fileIdsと見つかったファイルの数が異なる場合はエラーにする

* NO_SUCH_FILE

* Update codecov.yml

* Update apple-touch-icon.png

* デプロイされているプレビュー環境がない場合はプレビュー環境を削除しないようにする (#10062)

* デプロイされているプレビュー環境がない場合はDestroy preview environmentを実行しないようにする

* CIがない場合の処理追加

* enhance(client): improve clip menu ux

* 未知のユーザーが deleteActor されたら処理をスキップする (#10067)

* fix(client): Android ChromeでPWAとしてインストールできない問題を修正 (#10069)

* fix(client): Android ChromeでPWAとしてインストールできない問題を修正

* 順番関係ある?

* Windows環境でswcを使うと正常にビルドができない問題の修正 (#10074)

* Update @swc/core to v1.3.36

* Update CHANGELOG.md

* Update CHANGELOG.md

* バックグラウンドで一定時間経過したらページネーションのアイテム更新をしない (#10053)

* 🎨

* feat: 2つの検索画面の統合 (#9949) (#10038)

* feat: 検索画面の UI を統一

* fix: エラーの修正

* add: changelog

---------

Co-authored-by: syuilo <[email protected]>

* enhance(client): ノートメニューからユーザーメニューを開けるように

Resolve #10019

* enhance(client): renoteした際の表示を改善

Resolve #10078

* Update CHANGELOG.md

* enhance(client): tweak contextmenu position calculation

* 🎨

* 🎨

* feat: in-channel featured note

Resolve #9938

* refactor(frontend): fix eslint error (#10084)

* Simplify search.vue (remove dead code) (#10088)

* Simplify search.vue

This is already handled by the code above it, no need to handle it twice

* Remove unused imports

* Update about-misskey.vue

* test(server): add validation test of api:notes/create (#10090)

* fix(server): notes/createのバリデーションが効いていない
Fix #10079

Co-Authored-By: mei23 <[email protected]>

* anyOf内にバリデーションを書いても最初の一つしかチェックされない

* ✌️

* wip

* wip

* ✌️

* RequiredProp

* Revert "RequiredProp"

This reverts commit 7469390.

* add api:notes/create

* fix lint

* text

* ✌️

* improve readability

---------

Co-authored-by: mei23 <[email protected]>
Co-authored-by: syuilo <[email protected]>

* New Crowdin updates (#10059)

* New translations ja-JP.yml (Japanese, Kansai)

* New translations ja-JP.yml (Romanian)

* New translations ja-JP.yml (French)

* New translations ja-JP.yml (Spanish)

* New translations ja-JP.yml (Arabic)

* New translations ja-JP.yml (Czech)

* New translations ja-JP.yml (German)

* New translations ja-JP.yml (Italian)

* New translations ja-JP.yml (Korean)

* New translations ja-JP.yml (Polish)

* New translations ja-JP.yml (Russian)

* New translations ja-JP.yml (Slovak)

* New translations ja-JP.yml (Ukrainian)

* New translations ja-JP.yml (Chinese Simplified)

* New translations ja-JP.yml (Chinese Traditional)

* New translations ja-JP.yml (English)

* New translations ja-JP.yml (Vietnamese)

* New translations ja-JP.yml (Indonesian)

* New translations ja-JP.yml (Bengali)

* New translations ja-JP.yml (Thai)

* New translations ja-JP.yml (Japanese, Kansai)

* New translations ja-JP.yml (Chinese Traditional)

* New translations ja-JP.yml (Chinese Traditional)

* New translations ja-JP.yml (German)

* New translations ja-JP.yml (English)

* New translations ja-JP.yml (German)

* New translations ja-JP.yml (Ukrainian)

* New translations ja-JP.yml (Chinese Simplified)

* New translations ja-JP.yml (English)

* New translations ja-JP.yml (Ukrainian)

* New translations ja-JP.yml (Ukrainian)

* New translations ja-JP.yml (Ukrainian)

* New translations ja-JP.yml (Chinese Simplified)

* New translations ja-JP.yml (Japanese, Kansai)

* New translations ja-JP.yml (Thai)

* New translations ja-JP.yml (Thai)

* New translations ja-JP.yml (Thai)

* New translations ja-JP.yml (Spanish)

* New translations ja-JP.yml (Spanish)

* enhance(client): improve user menu ux

* enhance(client): photoswipe 表示時に戻る操作をしても前の画面に戻らないように (#10098)

* enhance(client): photoswipe 表示時に戻る操作をしても前の画面に戻らないように

* add: changelog

---------

Co-authored-by: syuilo <[email protected]>

* enhance(client): メニューの「もっと」からインスタンス情報を見れるように

* [Fix] fixed an typo in error message (#10102)

* Update codecov.yml

* Update CHANGELOG.md

* fix(server): エラーのスタックトレースは返さないように

Fix #10064

* [chore]Editorconfig: ymlに加えてyamlファイルに対しても同じ規約を適用する (#10081)

* Added yaml file in addition to yml file, in editorconfig

* Applied editorconfig for pnpm-workspace.yaml

---------

Co-authored-by: syuilo <[email protected]>

* update deps

* ホームタイムラインの読み込みでクエリタイムアウトになるのを修正する (#10106)

* refactor

* New translations ja-JP.yml (French) (#10103)

* Update CHANGELOG.md

* 13.8.0

---------

Co-authored-by: atsuchan <[email protected]>
Co-authored-by: Masaya Suzuki <[email protected]>
Co-authored-by: tamaina <[email protected]>
Co-authored-by: Kagami Sascha Rosylight <[email protected]>
Co-authored-by: taiy <[email protected]>
Co-authored-by: xianon <[email protected]>
Co-authored-by: kabo2468 <[email protected]>
Co-authored-by: YS <[email protected]>
Co-authored-by: Khsmty <[email protected]>
Co-authored-by: Soni L <[email protected]>
Co-authored-by: mei23 <[email protected]>
Co-authored-by: daima3629 <[email protected]>
Co-authored-by: Windymelt <[email protected]>
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #10667 (8b672fa) into develop (58c3fc6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #10667   +/-   ##
========================================
  Coverage    77.37%   77.37%           
========================================
  Files          899      899           
  Lines        89419    89421    +2     
  Branches      6534     6539    +5     
========================================
+ Hits         69184    69189    +5     
+ Misses       20235    20232    -3     
Impacted Files Coverage Δ
...ackend/src/server/api/endpoints/channels/search.ts 100.00% <100.00%> (+25.37%) ⬆️

... and 1 file with indirect coverage changes

@tar-bin
Copy link
Contributor Author

tar-bin commented May 1, 2023

@syuilo お忙しいところすみません。お手数ですが、こちらお時間のある時にレビューお願いできますでしょうか。

@syuilo
Copy link
Member

syuilo commented May 1, 2023

エンドポイントのテストがあると良さそうです!

@tar-bin
Copy link
Contributor Author

tar-bin commented May 1, 2023

@syuilo channel/searchエンドポイントのテスト追加しました。test/e2e/move.tsのテストが失敗してますが追加した分のテストはパスしてます。

@syuilo syuilo merged commit 8dab464 into misskey-dev:develop May 4, 2023
@syuilo
Copy link
Member

syuilo commented May 4, 2023

👍🏻

sasagar pushed a commit to sasagar/misskey that referenced this pull request May 9, 2023
…0667)

* Update CHANGELOG.md

* fix : able to search all channels

* add chennel/search test

* update Changelog

---------

Co-authored-by: tamaina <[email protected]>
Co-authored-by: syuilo <[email protected]>
Co-authored-by: atsuchan <[email protected]>
Co-authored-by: Masaya Suzuki <[email protected]>
Co-authored-by: Kagami Sascha Rosylight <[email protected]>
Co-authored-by: taiy <[email protected]>
Co-authored-by: xianon <[email protected]>
Co-authored-by: kabo2468 <[email protected]>
Co-authored-by: YS <[email protected]>
Co-authored-by: Khsmty <[email protected]>
Co-authored-by: Soni L <[email protected]>
Co-authored-by: mei23 <[email protected]>
Co-authored-by: daima3629 <[email protected]>
Co-authored-by: Windymelt <[email protected]>
Co-authored-by: Ebise Lutica <[email protected]>
na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
…0667)

* Update CHANGELOG.md

* fix : able to search all channels

* add chennel/search test

* update Changelog

---------

Co-authored-by: tamaina <[email protected]>
Co-authored-by: syuilo <[email protected]>
Co-authored-by: atsuchan <[email protected]>
Co-authored-by: Masaya Suzuki <[email protected]>
Co-authored-by: Kagami Sascha Rosylight <[email protected]>
Co-authored-by: taiy <[email protected]>
Co-authored-by: xianon <[email protected]>
Co-authored-by: kabo2468 <[email protected]>
Co-authored-by: YS <[email protected]>
Co-authored-by: Khsmty <[email protected]>
Co-authored-by: Soni L <[email protected]>
Co-authored-by: mei23 <[email protected]>
Co-authored-by: daima3629 <[email protected]>
Co-authored-by: Windymelt <[email protected]>
Co-authored-by: Ebise Lutica <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants