Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLの本文が消失する #8914

Closed
ikuradon opened this issue Jul 1, 2022 · 6 comments
Closed

TLの本文が消失する #8914

ikuradon opened this issue Jul 1, 2022 · 6 comments
Labels
🐛Bug Unexpected behavior 🌌Federation The Federation/ActivityPub feature packages/backend Server side specific issue/PR

Comments

@ikuradon
Copy link
Contributor

ikuradon commented Jul 1, 2022

💡 Summary

🥰 Expected Behavior

TLが正しく表示される

🤬 Actual Behavior

vivaldi_cbqJkeIgo8

📝 Steps to Reproduce

  1. 66b27bdc9765088468c216ff98015e1fadf77732にアップデートする
  2. Dockerイメージを作り、デプロイする
  3. 受信したTLを見る

📌 Environment

Misskey version: 66b27bd
Your OS:
Your browser:
@ikuradon ikuradon added the ⚠️bug? This might be a bug label Jul 1, 2022
@ikuradon
Copy link
Contributor Author

ikuradon commented Jul 1, 2022

30aa1dcdcd3f16eaaad0d41634390098f26c75a0まで戻したら直ったので、それ以降で壊れた可能性があるのかも

@ThatOneCalculator
Copy link
Contributor

ThatOneCalculator commented Jul 1, 2022 •
edited
Loading

I'm getting this issue too. @syuilo this should be considered high-priority/breaking.

@syuilo
Copy link
Member

syuilo commented Jul 1, 2022

parse5をメジャーアップデートしたのが原因だわね

@syuilo syuilo added 🐛Bug Unexpected behavior 🌌Federation The Federation/ActivityPub feature packages/backend Server side specific issue/PR and removed ⚠️bug? This might be a bug labels Jul 1, 2022
@ThatOneCalculator
Copy link
Contributor

It seems to happen whenever a non english-alphabetic letter is the first letter of a note.

@ThatOneCalculator
Copy link
Contributor

Never mind, that seems to have been a false assumption. It's seemingly random... :(

@mei23
Copy link
Contributor

mei23 commented Jul 1, 2022 •
edited
Loading

parse5をメジャーアップデートしたのが原因だわね

あーテストコケてるのこのせいなんだわね
https://github.com/misskey-dev/misskey/runs/7134543792?check_suite_focus=true#step:9:394

@mei23 mei23 mentioned this issue Jul 1, 2022
Merged
@syuilo syuilo closed this as completed in b846ebe Jul 1, 2022
soopyc pushed a commit to soopyc/misskey that referenced this issue Jul 1, 2022
@syuilo @soopyc
use parse5 6.0.1
d61cc2b 
Fix misskey-dev#8914
Jeder321 pushed a commit to Jeder321/misskey that referenced this issue Jul 15, 2022
@syuilo @Johann150
use parse5 6.0.1
b6a31bd 
Fix misskey-dev#8914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛Bug Unexpected behavior 🌌Federation The Federation/ActivityPub feature packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ikuradon @syuilo @mei23 @ThatOneCalculator