Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

フォロー、フォロワーの一覧を非公開にしていてもリモートサーバーで表示するとそのリモートサーバーにいるフォロワー分に限り見えてしまう #13362

Closed
1 task
meronmks opened this issue Feb 17, 2024 · 0 comments · Fixed by #14375
Labels
⚠️bug? This might be a bug 🌌Federation The Federation/ActivityPub feature

Comments

@meronmks
Copy link
Contributor

💡 Summary

フォローおよびフォロワーの一覧を非公開にしていたとしてもリモートサーバーで表示すると見えてしまう。
ただしすべてではなくあくまで該当のリモートサーバーのユーザをフォロー、フォロワーの一覧のみ
#12964 と同じくこの二つについても公開設定が連合していない?)

🥰 Expected Behavior

フォローおよびフォロワーの一覧の公開をオフにするとリモートサーバーからもそれぞれ表示されなくなる。
※ただし #13127 のようにモデレーションに影響が出ることが考えられる為権限がある場合は見えるように

🤬 Actual Behavior

フォローおよびフォロワーの一覧を非公開にしていてもリモートサーバーからは一覧が表示される

📝 Steps to Reproduce

  1. フォローもしくはフォロワーの公開設定をオフにする
  2. リモートサーバーでプロフィールを表示し、フォロー、フォロワーの数等の表示がある(そのリモートサーバーにフォローしている人、フォロワーが居なければ0と表示されるが、いる場合はその人数とユーザが閲覧できる)

💻 Frontend Environment

* Model and OS of the device(s):any
* Browser:any
* Server URL:any
* Misskey:2024.2.0

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service:any
* Misskey:2024.2.0
* Node:any
* PostgreSQL:any
* Redis:any
* OS and Architecture:any

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@meronmks meronmks added the ⚠️bug? This might be a bug label Feb 17, 2024
@t1nyb0x t1nyb0x moved this to Triage in [BUG TRACKER] Federation Apr 1, 2024
@t1nyb0x t1nyb0x moved this to Triage in [BUG TRACKER] Profile Apr 1, 2024
tesaguri added a commit to tesaguri/misskey that referenced this issue Aug 7, 2024
@syuilo syuilo closed this as completed in 0d508db Aug 9, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in [BUG TRACKER] Profile Aug 9, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in [BUG TRACKER] Profile Aug 9, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in [BUG TRACKER] Federation Aug 9, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in [BUG TRACKER] Federation Aug 9, 2024
LemonDouble pushed a commit to LemonDouble/misskey that referenced this issue Aug 19, 2024
… / feat: moderators can see following/followers of all users (misskey-dev#14375)

* fix(backend): check visibility of following/followers of remote users

Resolves misskey-dev#13362.

* test(backend): add tests for visibility of following/followers of remote users

* docs(changelog): update CHANGELOG.md

* feat: moderators can see following/followers of all users

* docs(changelog): update CHANGELOG.md

* refactor(backend): minor refactoring

`createPerson`と`if`の条件を統一するとともに、異常系の
処理をearly returnに追い出すための変更。

* feat(backend): moderators can see following/followers count of all users

As per misskey-dev#14375 (comment).
@samunohito samunohito added the 🌌Federation The Federation/ActivityPub feature label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug 🌌Federation The Federation/ActivityPub feature
Projects
Status: Done
Status: Done
2 participants