Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cat ears seems awkward on reply modal. #11279

Closed
RieLCho opened this issue Jul 14, 2023 · 2 comments · Fixed by #11309
Closed

Cat ears seems awkward on reply modal. #11279

RieLCho opened this issue Jul 14, 2023 · 2 comments · Fixed by #11309
Labels
🐛Bug Unexpected behavior packages/frontend Client side specific issue/PR

Comments

@RieLCho
Copy link
Contributor

RieLCho commented Jul 14, 2023 •
edited
Loading

💡 Summary

On reply modal, the cat ear seems quite awkward. Tried on Firefox 115.0.2 & Chrome 114.0. 5735. 199 and both seems wrong. I've tried to search this issue with 'cat', 'ear' to prevent making duplicated issue, but I'm really sorry if this issue is duplicated.

🥰 Expected Behavior

제목 없음

I think cat ears should be seen fully on reply modal.

or

fixed
giving a tag a margin-top:10px might fix this problem, but for only cat eared profiles.

🤬 Actual Behavior

image

📝 Steps to Reproduce

  1. Write a note.
  2. Get a reply from anyone who have a cat ear.
  3. Try to reply.

📌 Environment

💻 Frontend

  • Model and OS of the device(s): Windows 10 Education 22H2
  • Browser: Firefox 115.0.2 & Chrome 114.0.5735.199
  • Server URL: sns.lemondouble.com
  • Misskey: 13.14.0-beta.2
@RieLCho RieLCho added the ⚠️bug? This might be a bug label Jul 14, 2023
@RieLCho RieLCho changed the title Cat ears seems akward on reply modal. Cat ears seems awkward on reply modal. Jul 14, 2023
@saschanaz saschanaz added 🐛Bug Unexpected behavior packages/frontend Client side specific issue/PR and removed ⚠️bug? This might be a bug labels Jul 15, 2023
@saschanaz
Copy link
Member

I can confirm:
The cat ears are cut at the top boundary in the reply form

@RieLCho
Copy link
Contributor Author

RieLCho commented Jul 18, 2023

I think there could be two options.

  1. fix margin/padding
  • giving margin-bottom: -10px at components-MkPostForm-header & padding-top: 10px at .components-MkPostForm-targetNote
스크린샷 2023-07-18 오후 2 28 14
  1. fix z-index issue
  • every components are set to static so z-index will not work at all. needs more investigation.

I guess second option is better for future maintenance and component reuse. I really like your project and want to contribute. so I'll try to find out how to make this better.

RieLCho added a commit to RieLCho/misskey that referenced this issue Jul 18, 2023
@RieLCho
fix(frontend): misskey-dev#11279 adjusted margin & padding
e82a2d4
@RieLCho RieLCho mentioned this issue Jul 18, 2023
Merged
5 tasks
RieLCho added a commit to RieLCho/misskey that referenced this issue Jul 18, 2023
@RieLCho
Revert "fix(frontend): misskey-dev#11279 adjusted margin & padding"
60ef08b 
This reverts commit e82a2d4.
tamaina pushed a commit that referenced this issue Jul 19, 2023
@RieLCho
fix(frontend): Fix cat ears are awkward on reply modal (#11309)
5280a5e 
* fix(frontend): #11279 adjusted margin & padding

* Revert "fix(frontend): #11279 adjusted margin & padding"

This reverts commit e82a2d4.

* fix(frontend): adjusted margin & padding
yu256 pushed a commit to yu256/akatsukey that referenced this issue Jul 21, 2023
@RieLCho @yu256
fix(frontend): Fix cat ears are awkward on reply modal
0850490 
* fix(frontend): misskey-dev#11279 adjusted margin & padding

* Revert "fix(frontend): misskey-dev#11279 adjusted margin & padding"

This reverts commit e82a2d4.

* fix(frontend): adjusted margin & padding
slofp pushed a commit to Secineralyr/misskey.dream that referenced this issue Jul 21, 2023
@RieLCho @slofp
fix(frontend): Fix cat ears are awkward on reply modal (misskey-dev#1…
aded685 
…1309)

* fix(frontend): misskey-dev#11279 adjusted margin & padding

* Revert "fix(frontend): misskey-dev#11279 adjusted margin & padding"

This reverts commit e82a2d4.

* fix(frontend): adjusted margin & padding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛Bug Unexpected behavior packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(frontend): Fix cat ears are awkward on reply modal RieLCho/misskey
2 participants
@saschanaz @RieLCho