Skip to content

Commit

Permalink
bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388)
Browse files Browse the repository at this point in the history
Use Py_ssize_t type rather than int, to store lengths in
unionobject.c. Fix warnings:

Objects\unionobject.c(189,71): warning C4244: '+=':
conversion from 'Py_ssize_t' to 'int', possible loss of data

Objects\unionobject.c(182,1): warning C4244: 'initializing':
conversion from 'Py_ssize_t' to 'int', possible loss of data

Objects\unionobject.c(205,1): warning C4244: 'initializing':
conversion from 'Py_ssize_t' to 'int', possible loss of data

Objects\unionobject.c(437,1): warning C4244: 'initializing':
conversion from 'Py_ssize_t' to 'int', possible loss of data
  • Loading branch information
vstinner authored Sep 23, 2020
1 parent bbeb223 commit d67de0a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Objects/unionobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,8 @@ union_richcompare(PyObject *a, PyObject *b, int op)
static PyObject*
flatten_args(PyObject* args)
{
int arg_length = PyTuple_GET_SIZE(args);
int total_args = 0;
Py_ssize_t arg_length = PyTuple_GET_SIZE(args);
Py_ssize_t total_args = 0;
// Get number of total args once it's flattened.
for (Py_ssize_t i = 0; i < arg_length; i++) {
PyObject *arg = PyTuple_GET_ITEM(args, i);
Expand Down Expand Up @@ -434,7 +434,7 @@ _Py_Union(PyObject *args)
unionobject* result = NULL;

// Check arguments are unionable.
int nargs = PyTuple_GET_SIZE(args);
Py_ssize_t nargs = PyTuple_GET_SIZE(args);
for (Py_ssize_t iarg = 0; iarg < nargs; iarg++) {
PyObject *arg = PyTuple_GET_ITEM(args, iarg);
if (arg == NULL) {
Expand Down

0 comments on commit d67de0a

Please sign in to comment.