Skip to content

Commit

Permalink
pythongh-117389: Fix test_compileall.EncodingTest (python#117390)
Browse files Browse the repository at this point in the history
  • Loading branch information
sobolevn authored May 5, 2024
1 parent 5092ea2 commit 44f6791
Showing 1 changed file with 14 additions and 8 deletions.
22 changes: 14 additions & 8 deletions Lib/test/test_compileall.py
Original file line number Diff line number Diff line change
Expand Up @@ -502,19 +502,25 @@ def setUp(self):
self.directory = tempfile.mkdtemp()
self.source_path = os.path.join(self.directory, '_test.py')
with open(self.source_path, 'w', encoding='utf-8') as file:
file.write('# -*- coding: utf-8 -*-\n')
file.write('print u"\u20ac"\n')
# Intentional syntax error: bytes can only contain
# ASCII literal characters.
file.write('b"\u20ac"')

def tearDown(self):
shutil.rmtree(self.directory)

def test_error(self):
try:
orig_stdout = sys.stdout
sys.stdout = io.TextIOWrapper(io.BytesIO(),encoding='ascii')
compileall.compile_dir(self.directory)
finally:
sys.stdout = orig_stdout
buffer = io.TextIOWrapper(io.BytesIO(), encoding='ascii')
with contextlib.redirect_stdout(buffer):
compiled = compileall.compile_dir(self.directory)
self.assertFalse(compiled) # should not be successful
buffer.seek(0)
res = buffer.read()
self.assertIn(
'SyntaxError: bytes can only contain ASCII literal characters',
res,
)
self.assertNotIn('UnicodeEncodeError', res)


class CommandLineTestsBase:
Expand Down

0 comments on commit 44f6791

Please sign in to comment.