Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ItemsCount to raise ValueError #203

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fixed ItemsCount to raise ValueError #203

merged 2 commits into from
Jan 23, 2024

Conversation

AryazE
Copy link
Contributor

@AryazE AryazE commented Jan 23, 2024

When the value in ItemsCount's constructor is not of a valid type, this line is supposed to raise a ValueError, but it does not.
This PR fixes that.

miso-belica
miso-belica approved these changes Jan 23, 2024
View reviewed changes
Copy link
Owner

@miso-belica miso-belica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. It was there for ages. I would probably put the check into __init__ now, but it's OK like this. Thank you 🙂

@miso-belica miso-belica merged commit 0bcec9f into miso-belica:main Jan 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miso-belica miso-belica miso-belica approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AryazE @miso-belica