Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround tty bugs on Node.js #4594

Merged
merged 1 commit into from
Jan 26, 2021
Merged

workaround tty bugs on Node.js #4594

merged 1 commit into from
Jan 26, 2021

Conversation

alexlamsl
Copy link
Collaborator

@kzc though #4529 (comment) didn't pan out, it dawned on me some of those recent false positives from ufuzz is likely courtesy of Node.js

@alexlamsl alexlamsl merged commit 4723b45 into mishoo:master Jan 26, 2021
@alexlamsl alexlamsl deleted the sandbox branch January 26, 2021 15:07
@kzc
Copy link
Contributor

kzc commented Jan 26, 2021

At least something positive came out of it.

I did notice an usual number of failures in ufuzz testing. But when I looked at a few they seemed like const variable use before initialization issues and property references on undefined in the original test cases.

@alexlamsl
Copy link
Collaborator Author

alexlamsl commented Jan 26, 2021

Temporal Dead Zones ones are all caused by forward references through typeof fn == "function" && fn(...), and they are both rare, won't trigger false positives, and actually useful against things like #2750

Those cannot set property ones are caused by code like this:

var a = {};
a && ([ a.p ] = [ a = null ]);

These do trigger false positives from time to time, as the string representation may differ after AST_Sub.property gets uglified.

@kzc
Copy link
Contributor

kzc commented Jan 26, 2021

I've got to hand it to you, sifting through all those ufuzz failures is a lot of work. Better automation of test case reduction only leads to more cases to examine.

@alexlamsl
Copy link
Collaborator Author

Well at least these reports are full of verifiable/reproducible details... 😏

@kzc
Copy link
Contributor

kzc commented Jan 26, 2021

I'm still waiting for someone to file an UGLIFY_BUG_REPORT.

@alexlamsl
Copy link
Collaborator Author

May happen sooner if we add EXPORT_GPL() to the output... 🤔

@kzc
Copy link
Contributor

kzc commented Jan 26, 2021

I was unaware of that until I just googled it. Yes, that would work. :-)

@kzc
Copy link
Contributor

kzc commented Jan 27, 2021

Fewer ufuzz failures after this PR was merged.

@alexlamsl
Copy link
Collaborator Author

alexlamsl commented Jan 27, 2021

Yup, mystery solved − I was unable to recreate all those [object Object] locally even after 10MFuzz...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants