-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change. #5837
Comments
Thanks for the report, but that's not how version numbering works in this project. |
@alexlamsl Sorry for the disturbance but I do think that a change of default configuration IS a breaking change. Such is agreed on in this StackExchange thread:
And also by the Microsoft dotnet contributors in their Breaking Change Rules:
Currently this change is already causing problems in our project, forcing us to lock version for I would suggest re-opening this issue, publishing a new |
I do not work for or sponsored by any of such entities you've mentioned, so I don't see why I should heed any of their rules and/or opinions. |
@alexlamsl It’s about basic understanding of semantic versioning. Most packages on npm obey the rules of semantic versioning, and it’s the assumption of package managers like npm and yarn, in order that the whole system can work together. Currently this change in uglify-js is breaking the system, which is why it should be corrected. |
@alexlamsl we should follow this standard to make it much easier and safer to use newer versions of UglifyJS without worrying about "hidden" breaking changes. |
Unfortunately, UglifyJS does not follow semantic release standards. And I couldn't figure out a way to pass the module parameter via the grunt task. mishoo/UglifyJS#5837
Unfortunately, UglifyJS does not follow semantic release standards. And I couldn't figure out a way to pass the module parameter via the grunt task. mishoo/UglifyJS#5837
The last release is considered a breaking change since default input was changed, following semver the new version should be 4.0.0.
I was using a pipeline with grunt and grunt-contrib-uglify, but grunt-contrib-uglify requires "uglify-js": "^3.13.3" which allows only minor non breaking changes, now it breaks any pipeline that relies upon the default value and has code not compliant with "use strict".
Previous uglify-js version 3.17.4
New uglify-js version 3.18.0
Reference:
v3.17.4...v3.18.0#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L533-L536
I will fix my pipeline by downgrading to [email protected]
The text was updated successfully, but these errors were encountered: