Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 3.3.24 seems to be incorrectly processing query-builder.standalone.xml #3127

Closed
hopkink1 opened this issue May 9, 2018 · 2 comments · Fixed by #3128
Closed

version 3.3.24 seems to be incorrectly processing query-builder.standalone.xml #3127

hopkink1 opened this issue May 9, 2018 · 2 comments · Fixed by #3128
Labels

Comments

@hopkink1
Copy link

hopkink1 commented May 9, 2018

Bug report

3.3.24

This input:
_globals = (function(){ return this || (0,eval)("this"); }());
was getting minified by 3.3.21 to
a=function(){return this||(0,eval)("this")}()
but with 3.3.24 it's being minified to
s=function(){return this||eval("this")}()

This discrepancy seems to be leading to this error message:
TypeError: s is undefined[Learn More]
query-builder.standalone.js:9:2126

...js/lib/query-builder.standalone.js:9:2126

...js/lib/query-builder.standalone.js:9:1093

options: {
output: {
comments: "/^/*!/"
}
}

The input that we are trying to minify comes from:
https://raw.githubusercontent.com/mistic100/jQuery-QueryBuilder/2.5.1/dist/js/query-builder.standalone.js

@alexlamsl
Copy link
Collaborator

alexlamsl commented May 9, 2018

I see the problem now - "use strict"; makes a difference.

Fix coming up.

@alexlamsl alexlamsl added the bug label May 9, 2018
alexlamsl added a commit to alexlamsl/UglifyJS that referenced this issue May 9, 2018
alexlamsl added a commit that referenced this issue May 9, 2018
@hopkink1
Copy link
Author

hopkink1 commented May 9, 2018

Thanks for the quick turn around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants