Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis-CI with GitHub actions #484

Merged
merged 7 commits into from
Mar 5, 2021
Merged

Conversation

rafalp
Copy link
Contributor

@rafalp rafalp commented Mar 4, 2021

Fixes #268 and #483

Removes Travis CI and adds GH actions instead.

Note: pip-compile insists on including typed-ast which is not supported for Python 3.8 and outright crashes installation on Python 3.9, hence the separate dev deps file for python 3.9.

Maybe we should drop Mypy/pylint/black from dev deps and install it only on CI step?

@rafalp rafalp added this to the Ariadne 0.13 milestone Mar 4, 2021
@rafalp rafalp self-assigned this Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #484 (b2a1f94) into master (d435262) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   98.18%   98.16%   -0.02%     
==========================================
  Files         104      104              
  Lines        5123     5125       +2     
==========================================
+ Hits         5030     5031       +1     
- Misses         93       94       +1     
Impacted Files Coverage Δ
ariadne/graphql.py 89.92% <ø> (ø)
ariadne/asgi.py 95.21% <100.00%> (-0.03%) ⬇️
ariadne/contrib/django/views.py 100.00% <100.00%> (ø)
ariadne/contrib/federation/utils.py 100.00% <100.00%> (ø)
ariadne/extensions.py 100.00% <100.00%> (ø)
ariadne/schema_visitor.py 94.16% <100.00%> (ø)
ariadne/types.py 96.55% <100.00%> (+0.12%) ⬆️
ariadne/utils.py 100.00% <100.00%> (ø)
ariadne/wsgi.py 95.65% <100.00%> (-0.04%) ⬇️
tests/test_camel_case_to_snake_case_convertion.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd5f19...b2a1f94. Read the comment docs.

@rafalp rafalp requested a review from bogdal March 4, 2021 21:19
@rafalp rafalp added the meta label Mar 4, 2021
Copy link
Member

@bogdal bogdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rafalp rafalp merged commit a732a7c into master Mar 5, 2021
@rafalp rafalp deleted the fix-268-add-gh-actions branch March 5, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from Travis to GitHub actions
2 participants