This repository has been archived by the owner on Jul 18, 2018. It is now read-only.
forked from ChromiumWebApps/chromium
-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Correct the skip-waiting-installed.html behavior
According to the latest spec, the skipWaiting promise should be resolved after 'activate' event is dispatched. This change is from w3c/ServiceWorker#1065. Tracing through the spec, skipWaiting() enters "Try Activate". "Try Activate" invokes "Activate". "Activate" blocks until the final step: "13. Run the Update Worker State algorithm passing registration’s active worker and activated as the arguments." "Update Worker State" queues a task to set ServiceWorker#state to 'activated'. But in step 10, we have dispatched the 'activate' event. Therefore the order should be: 1. 'activate' event handler runs 2. skipWaiting() promise resolves 3. ServiceWorker#state is set to 'activated' So we correct the test case here and delete all the wrong expected files. BUG=725616 Change-Id: Id0765988c7cdf48f39bb73ccb3fc0cce6ea60949 Reviewed-on: https://chromium-review.googlesource.com/646244 Commit-Queue: Matt Falkenhagen <[email protected]> Reviewed-by: Matt Falkenhagen <[email protected]> Cr-Commit-Position: refs/heads/master@{#499513}
- Loading branch information
Showing
8 changed files
with
10 additions
and
135 deletions.
There are no files selected for viewing
22 changes: 10 additions & 12 deletions
22
...ts/external/wpt/service-workers/service-worker/resources/skip-waiting-installed-worker.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 0 additions & 4 deletions
4
...sts/external/wpt/service-workers/service-worker/skip-waiting-installed.https-expected.txt
This file was deleted.
Oops, something went wrong.
67 changes: 0 additions & 67 deletions
67
third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.skip-waiting-installed.html
This file was deleted.
Oops, something went wrong.
36 changes: 0 additions & 36 deletions
36
...ty/WebKit/LayoutTests/http/tests/serviceworker/resources/skip-waiting-installed-worker.js
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
...obs/external/wpt/service-workers/service-worker/skip-waiting-installed.https-expected.txt
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
...ing/external/wpt/service-workers/service-worker/skip-waiting-installed.https-expected.txt
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
...obs/external/wpt/service-workers/service-worker/skip-waiting-installed.https-expected.txt
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
...ing/external/wpt/service-workers/service-worker/skip-waiting-installed.https-expected.txt
This file was deleted.
Oops, something went wrong.