ignored ids from file works only if the file is defined

mirego · Mar 19, 2024 · 621747d · 621747d
1 parent 9b2aa9d
commit 621747d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -58,7 +58,7 @@ $ mix deps.audit
 | `--format`               | String | `"human"`           | The format of the report to generate (`"json"` or `"human"`) |
 | `--ignore-advisory-ids`  | String | `""`                | Comma-separated list of advisory IDs to ignore               |
 | `--ignore-package-names` | String | `""`                | Comma-separated list of package names to ignore              |
-| `--ignore-file`          | String | `.mix-audit-skips`  | Path of the ignore file                                      |
+| `--ignore-file`          | String | `""`                | Path of the ignore file                                      |
 
 ## Example
 

diff --git a/lib/mix_audit/cli/audit.ex b/lib/mix_audit/cli/audit.ex
@@ -48,11 +48,15 @@ defmodule MixAudit.CLI.Audit do
     |> Enum.map(&String.trim/1)
   end
 
-  defp ignored_ids_from_file(opts) do
-    opts
-    |> Keyword.get(:ignore_file, ".mix-audit-skips")
-    |> File.read!()
-    |> String.split("\n")
-    |> Enum.reject(fn line -> String.starts_with?(line, "#") || String.trim(line) == "" end)
+  def ignored_ids_from_file(opts) do
+    case Keyword.get(opts, :ignore_file) do
+      nil ->
+        []
+
+      ignore_file ->
+        File.read!(ignore_file)
+        |> String.split("\n")
+        |> Enum.reject(fn line -> String.starts_with?(line, "#") || String.trim(line) == "" end)
+    end
   end
 end