Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Elixir/Erlang versions in CI #34

Closed
wants to merge 1 commit into from

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Jun 9, 2023

📖 Description and reason

Ensure support of the library for latest Elixir/Erlang versions.

👷 Work done

Tasks

  • Bump Elixir/Erlang version in GitHub Action config.
  • Bump Credo and Excoveralls to make it works with all Elixir/Erlang versions.
  • Bump project minimum Elixir requirement to 1.8.
  • Regenerate and update .credo.exs.
  • Update GitHub Action CI to run on master branch.

Additional notes

🎉 Result

🦀 Dispatch

#dispatch/elixir

@kianmeng
Copy link
Contributor Author

kianmeng commented Jun 9, 2023

Note that it won't work with Erlang/OTP 26:

Compiling 56 files (.ex)
warning: atom ::: must be written between quotes, as in :"::", to avoid ambiguity
  lib/ecto/query/builder.ex:246:8


== Compilation error in file lib/ecto/query.ex ==
** (CompileError) lib/ecto/query.ex:427: type dynamic/0 is a built-in type and it cannot be redefined
    (elixir 1.14.5) lib/kernel/typespec.ex:936: Kernel.Typespec.compile_error/2
    (stdlib 5.0.1) lists.erl:1599: :lists.foldl_1/3
    (elixir 1.14.5) lib/kernel/typespec.ex:226: Kernel.Typespec.translate_typespecs_for_module/2
could not compile dependency :ecto, "mix compile" failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile ecto", update it with "mix deps.update ecto" or clean it with "mix deps.clean ecto"

@remi
Copy link
Member

remi commented Sep 22, 2024

I don’t know why the CI builds didn’t run in this PR… I’m working on bringing support for Elixir 1.16 and 1.17 so we’ll be able to close this one 🙂

@kianmeng
Copy link
Contributor Author

Superseded by #37

@kianmeng kianmeng closed this Sep 22, 2024
@remi
Copy link
Member

remi commented Sep 24, 2024

@kianmeng Version 1.2.0 has been released with support for newer OTP/Elixir versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants