Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/47 update docker based version stable r #48

Merged
merged 15 commits into from
Aug 14, 2024

Conversation

spoltier
Copy link
Member

Draft for discussion

@spoltier spoltier linked an issue Jun 18, 2024 that may be closed by this pull request
@spoltier spoltier force-pushed the feature/47-update-docker-based-version-stable-r branch from 56763e4 to a1fef69 Compare June 19, 2024 11:58
@spoltier
Copy link
Member Author

This should be ready for review apart from the podman issue (which could be pushed to a later ticket).
There are other aspects that could be changed, but would be a bit of a change in approach, so could be considered out of scope for the update part.

version-stable-r-development.Rmd Outdated Show resolved Hide resolved
version-stable-r-development.Rmd Outdated Show resolved Hide resolved
version-stable-r-development.Rmd Outdated Show resolved Hide resolved
version-stable-r-development.Rmd Show resolved Hide resolved
version-stable-r-development.Rmd Outdated Show resolved Hide resolved
version-stable-r-development.Rmd Outdated Show resolved Hide resolved
version-stable-r-development.Rmd Outdated Show resolved Hide resolved
@spoltier spoltier marked this pull request as ready for review July 1, 2024 15:31
Copy link
Member

@riccardoporreca riccardoporreca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spoltier, see some minor feedback.

I actually tried this for SmaRP, things seem to work fine with the exception of using Meld within the container

(meld:1038): dbind-WARNING **: 13:59:04.184: Couldn't connect to accessibility bus: Failed to connect to socket /run/user/1001/at-spi/bus: No such file or directory
Trace/breakpoint trap (core dumped)

It looks like the existing instructions about DISPLAY and X11 stuff don't work. Happy to open a separate issue for this.

version-stable-r-development.Rmd Show resolved Hide resolved
version-stable-r-development.Rmd Outdated Show resolved Hide resolved
version-stable-r-development.Rmd Show resolved Hide resolved
@spoltier
Copy link
Member Author

@spoltier, see some minor feedback.

I actually tried this for SmaRP, things seem to work fine with the exception of using Meld within the container

(meld:1038): dbind-WARNING **: 13:59:04.184: Couldn't connect to accessibility bus: Failed to connect to socket /run/user/1001/at-spi/bus: No such file or directory
Trace/breakpoint trap (core dumped)

It looks like the existing instructions about DISPLAY and X11 stuff don't work. Happy to open a separate issue for this.

Agree. I am able to reproduce this error now, but I was able to use Meld + compareWith when testing previously.
I tried older container images but these also show the same behavior. I suspect a patch on the host system may have changed the behavior - X11 is considered insecure and may be more restricted by default on up-to-date systems.
On 24.04 (VM), I also get a different error:
image

Copy link
Member

@riccardoporreca riccardoporreca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's defer investigating the Meld problem to a follow-up issue

@spoltier
Copy link
Member Author

LGTM, let's defer investigating the Meld problem to a follow-up issue

indeed, opened #49

@spoltier spoltier merged commit 9a8dda7 into master Aug 14, 2024
4 checks passed
@spoltier spoltier deleted the feature/47-update-docker-based-version-stable-r branch August 14, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docker-based version-stable R
3 participants