-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/96 plot in report #98
Conversation
fvitalini
commented
Mar 12, 2019
•
edited by riccardoporreca
Loading
edited by riccardoporreca
- correct names in plot colour fill (closes Bar plot not showing properly in Report in version 1.1.0 #96)
- align plot labels to the tables in the report.
@fvitalini, I think we should be more explicit about what was done here. The main driver was fixing bug #96. On top of this, plot labels were changed from What is definitely missing is mentioning bugfix #96 in * Fixed missing bar-plot in the PDF report (#6).
* Reviewed plots labels. Actually, naming probably deserves its own issue, since we are not very consistent between plots, table, text in the report. I opened a dedicated issue #103, we might want to revert the labels change done here and delegate it to it. |
@riccardoporreca In commit 32dadde I have updated the NEWS.md according to your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As clarified with @fvitalini and @gabrielfoix, the pull request also covers, on top of bugfix #96, the renaming the plot legends to make them consistent with the report tables. News.md updated accordingly to be more explicit (dba29da).