Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: only apply ssl service if the domain doesn't end in .miraheze.org #4027

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MacFan4000
Copy link
Member

This reduces the number of redundant checks for miraheze.org, which already has a check defined towards the beginning of this file.

@paladox
Copy link
Contributor

paladox commented Oct 16, 2024

We need the ssl cert expiry monitoring. But also events are disabled via disable_event.

@MacFan4000
Copy link
Member Author

We need the ssl cert expiry monitoring. But also events are disabled via disable_event.

As mentioned above the miraheze.org cert is already monitored by a separate entry in the config. There is zero reason to have it monitored many times extra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants