Allow for setupMirage to pass options to startMirage #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
approved these changes
Mar 21, 2022
tests/dummy/app/pods/docs/testing/integration-and-unit-tests/template.md
Outdated
Show resolved
Hide resolved
SergeAstapov
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2370
startMiragetakes an options parameter to aid in creating the server. AllowedsetupMirageto also take an options param and pass tostartMirage.@dfreeman Not good with TS. Could you make a followup PR after this is merged to update the
test-support.d.tsif thats where the types should go. Since these options are passed tostartMirage, it should also have a type def, there are times when it can be called directly, which may mean the default export frommirage/config.jsmay also need a type.