Optional named params fix #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Ludlam <[email protected]>
Named parameters are marshalled into a dictionary, unless they are option typed, where a 'None' is simply absent from the dictionary and 'Some x' puts 'x' into the dict. When _all_ named parameters are option typed and are _all_ 'None' the Client modules would previously assume there weren't any named params and incorrectly omit the dictionary. Signed-off-by: Jon Ludlam <[email protected]>
gaborigloi
approved these changes
Jul 12, 2018
There was a problem hiding this comment.
Looks good!
We've discussed that the alternative fix in the server, indicating that none of the optional named params are present by the absence of the first dictionary, is incorrect, it does not work when the first unnamed param itself is a dictionary. Thus we must send an empty dictionary, if all the named params are optional and absent.
We should merge #117 soon to avoid having to do the same fix 3 times. 😅
|
Agreed about #117 - we just need to schedule a chunk of time to look at the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for named parameters that have option types.