git-mirage: avoid failwith, use exit 64 (argument error) #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jun 11, 2024
CHANGES: - Fix the compilation of `git-unix` with `mimic-happy-eyeballs.0.0.8` (@dinosaure, mirage/ocaml-git#642) - Print out errors when we got an error on unikernels (@hannesm, mirage/ocaml-git#641)
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: - Fix the compilation of `git-unix` with `mimic-happy-eyeballs.0.0.8` (@dinosaure, mirage/ocaml-git#642) - Print out errors when we got an error on unikernels (@hannesm, mirage/ocaml-git#641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue I observed was a unikernel that restarted all the time, but its argument had an issue "wrong padding" was the output, but while there was a backtrace, there was no useful information. I tracked it back that git-mirage-ssh got a ssh private key where the padding was bad.
So, this PR does (a) prefix the output with slightly more information and (b) returns exit code 64 (as defined in Mirage_runtime.argument_error) -- this is crucial since albatross then won't restart such a unikernel (that will not be able to succeed a startup, since the error will persist until the command line argument is changed).