Fix raw parsing in middle of buffer #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address issue with `of_raw_with_header` assuming it could read until the end of a given buffer and add a new function, `length_with_header`, that clients can use to inspect length read.
dinosaure
approved these changes
Aug 27, 2023
|
Seems good, thanks for your work, I will try to cut a release as soon as I can. |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Sep 30, 2023
CHANGES: - Fix tests with `git.2.41.0+` (@metanivek, mirage/ocaml-git#622) - Fix raw parsing in the middle of the buffer (@metanivek, mirage/ocaml-git#623)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Fix tests with `git.2.41.0+` (@metanivek, mirage/ocaml-git#622) - Fix raw parsing in the middle of the buffer (@metanivek, mirage/ocaml-git#623)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue with
of_raw_with_headerassuming it could read until the end of a given buffer and add a new function,length_with_header, that clients can use to inspect length read.I ran into this while working on testing
irmin-server. Its protocol (de)serializes blobs in the middle of a buffer, which does not work when using anirmin-gitstore. I have verified that this patch (with appropriate changes inirmin-git) fixes the issue for us.