Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify printer and zone output #287

Open
hannesm opened this issue Jan 12, 2022 · 0 comments
Open

unify printer and zone output #287

hannesm opened this issue Jan 12, 2022 · 0 comments

Comments

@hannesm
Copy link
Member

hannesm commented Jan 12, 2022

at the moment, there are distinct zone output and a pretty printer, which results in pretty substantial amount of code, and also the output of log messages (using pp) is inconsistent with the common zone file format.

instead, unify them (maybe with a ?pretty flag to indicate whether to output e.g. algorithm names (for humans) or numbers (for interoperability)).

as a step afterwards, there should be test cases taking a zone file as input, and ensuing that it is correctly parsed, and also the textual output is the same as the input -- it may also be sensible to generate random zones, outputting them, decoding them, and checking equality.

hannesm added a commit to hannesm/ocaml-dns that referenced this issue Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant