add server type (`Listening_socket of Lwt_unix.file_descr) #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks right to me -- just requesting another review from @djs55 who wrote the launchd backend |
|
bump? |
|
Merging, thanks! |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Jul 15, 2019
…nd mirage-conduit (1.5.0) CHANGES: * lwt-unix: Do not close file descriptors more than once, which led to a lot of log spam due to EBADF (mirage/ocaml-conduit#294 @hcarty @avsm) * lwt-unix: Always close channels after handling an event (mirage/ocaml-conduit#283 @hcarty) * Allow TCP to be established from existing file descriptors (for example, an inherited systemd socket) (mirage/ocaml-conduit#144 @SGrondin mirage/ocaml-conduit#282 @timbertson) * async: add `Conduit_async.V3` which provides convenience functions for resolving URIs to addresses (mirage/ocaml-conduit#287 @vbmithr) * `Lwt_ssl`: Enable certification validation (mirage/ocaml-conduit#291 @vouillon) * `Async_ssl`: fix exception raised when other side disconnects due to sharing underlying fd (mirage/ocaml-conduit#295 @bogdan2412)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #281 . The variant had to be of type
sexp_opaquebecausefile_descris abstract. That would cause a runtime error trying to serialize one of these, but I assume it won't break other variants.(network buffs: is "listening socket" the right description for an inherited systemd socket? AFAIK you don't need to call
listenbut you do need to callaccepton such a socket, so it sounds right to me)