Fix cancelation of UNIX sockets and let a chance to run the listen loop if we craft our TCP stack xor UDP stack on our own way #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, I suspect that for udp{v4,v6,v4v6}_socket.ml the same should be applied. |
…op if we craft our TCP stack xor UDP stack on our own way
dinosaure
force-pushed
the
fix-cancelation-of-sockets
branch
from
41e276e
to
674d8d6
Compare
|
I'm not sure if @talex5 is available to look on it but the PR seems ok to merge. |
|
Let's merge, I'm confident with this fix. |
|
ok, cool. should I cut a release with this fix? or do you want to cut a release? |
|
I can cut the release by myself 👍 . |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Dec 17, 2021
CHANGES: * Fix cancelation of Unix socket when we don't use `Stack.connect` (@dinosaure, @hannesm, mirage/mirage-tcpip#466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a probable fix about cancellation of sockets and a fix for #464. I would like a double check for an lwt expert (@talex5 ?) and @hannesm 👍!