adapt to mirage/mirage#1004 API changes #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2019
- ip is a required keyword of type Ipaddr.V4.Prefix.t * Ipaddr.V4.t - the network argument is gone (superseeded by being integrated into ip above) - ?gateway is Ipaddr.V4.t (used to be Ipaddr.V4.t option) --> connect cannot fail anymore :)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Nov 1, 2019
CHANGES: * Adapt to mirage-protocols 4.0.0, mirage-net 3.0.0, mirage-time 2.0.0, mirage-clock 3.0.0, mirage-stack 2.0.0 interface changes (mirage/mirage-tcpip#420 @hannesm) * Revise Static_ipv4.connect signature (for more safety): val connect : ip:(Ipaddr.V4.Prefix.t * Ipaddr.V4.t) -> ?gateway:Ipaddr.V4.t -> ?fragment_cache_size:int -> E.t -> A.t -> t Lwt.t it used to be: val connect : ?ip:Ipaddr.V4.t -> ?network:Ipaddr.V4.Prefix.t -> ?gateway:Ipaddr.V4.t option -> C.t -> E.t -> A.t -> t Lwt.t The clock `C.t` is gone (due to mirage-clock 3.0.0), `~ip` and `~network` are now required and passed as pair `~ip`. The optional argument `?gateway` is of type Ipaddr.V4.t. The new optional labeled argument `~fragment_cache_size` specifies the byte size of the IPv4 fragment cache (mirage/mirage-tcpip#420 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.