Ipv4.Fragments: use a mutable LRU cache (Lru.M.t instead of mutable cache : Lru.F.t) #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ache : Lru.F.t): - is faster (O(1) instead of O(log n)) - still avoids (due to randomization) collision-based complexity
|
CI failures are due to old (gcc < 4.9) linux distributions trying (and failing) to compile solo5. |
Merged
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Oct 15, 2019
CHANGES: * Add ?ttl:int parameter to Udp and Icmp write (mirage/mirage-tcpip#416 @phaer) * Ipv4.Fragments use a Lru.M.t instead of Lru.F.t (mirage/mirage-tcpip#418 @hannesm) * Adapt to mirage-protocols 3.1.0 changes (mirage/mirage-tcpip#419 @hannesm) - removed IP.set_ip - added `Would_fragment to Ip.error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as suggested by @pqwy in mirage/mirage-nat#28 (comment) (see as well the brief overview of Lru at https://pqwy.github.io/lru/doc/lru/Lru/index.html)
it also simplifies the API of the Fragments module, and makes it easier to use! :)