Update to latest X509 and DNS APIs. #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcgilchrist
force-pushed
the
updates
branch
2 times, most recently
from
edf8a3e
to
71e92c8
Compare
|
Could you rebase this on top of master? Thanks! |
talex5
reviewed
Oct 22, 2021
CHANGES.md
Outdated
| @@ -32,41 +37,41 @@ | |||
|
|
|||
| ### v0.9.0 | |||
|
|
|||
| - Add connection progress indicator (@talex5 #220). | |||
There was a problem hiding this comment.
Are these changes intentional? Trailing space is significant in markdown (forces a linebreak).
There was a problem hiding this comment.
@talex5 woops sorry I haven't realised these spaces have semantics. I guess @tmcgilchrist has the same editor configuration as mine which removes trailing spaces automatically.
Do you want me to revert #239 ?
There was a problem hiding this comment.
I'll re-instate the whitespaces, Emacs tidies up extra whitespace automatically when sometimes it shouldn't.
talex5
approved these changes
Nov 1, 2021
|
Any chance we could have a release with this change? |
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Nov 5, 2021
…age and capnp-rpc-lwt (1.2.1) CHANGES: - Fix Fmt deprecation warnings (@tmcgilchrist mirage/capnp-rpc#239). - Update to latest X509 and DNS APIs (@tmcgilchrist mirage/capnp-rpc#240).
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Nov 5, 2021
…age and capnp-rpc-lwt (1.2.1) CHANGES: - Fix Fmt deprecation warnings (@tmcgilchrist mirage/capnp-rpc#239). - Update to latest X509 and DNS APIs (@tmcgilchrist mirage/capnp-rpc#240).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #239