Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require fmt >= 0.8.7 for kstr #232

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Require fmt >= 0.8.7 for kstr #232

merged 1 commit into from
Apr 27, 2021

Conversation

talex5
Copy link
Contributor

@talex5 talex5 commented Apr 27, 2021

No description provided.

Also, set OCaml 4.08 as the minimum version everywhere.
Older versions aren't tested in CI because the unix and mirage packages
require at least OCaml 4.08.
@talex5 talex5 merged commit 38c76c2 into mirage:master Apr 27, 2021
@talex5 talex5 deleted the bound-fmt branch April 27, 2021 10:40
talex5 added a commit to talex5/opam-repository that referenced this pull request Jun 10, 2021
…nix and capnp-rpc-lwt (1.2)

CHANGES:

- Don't crash if the peer disconnects before the bootstrap reply is ready (@talex5 mirage/capnp-rpc#234).
  When replying to a normal question we checked that the answer was still needed before trying to reply, but didn't for bootstrap requests.

- Replace `wait_until_settled` with safer `await_settled` (@talex5 mirage/capnp-rpc#233).
  `wait_until_settled` makes it too easy to ignore errors.

- Require fmt >= 0.8.7 for `kstr` and set OCaml 4.08 as the minimum version everywhere (@talex5 mirage/capnp-rpc#232).
  Older versions aren't tested in CI because the unix and mirage packages require at least OCaml 4.08.
talex5 added a commit to talex5/opam-repository that referenced this pull request Jun 10, 2021
…nix and capnp-rpc-lwt (1.2)

CHANGES:

- Don't crash if the peer disconnects before the bootstrap reply is ready (@talex5 mirage/capnp-rpc#234).
  When replying to a normal question we checked that the answer was still needed before trying to reply, but didn't for bootstrap requests.

- Replace `wait_until_settled` with safer `await_settled` (@talex5 mirage/capnp-rpc#233).
  `wait_until_settled` makes it too easy to ignore errors.

- Require fmt >= 0.8.7 for `kstr` and set OCaml 4.08 as the minimum version everywhere (@talex5 mirage/capnp-rpc#232).
  Older versions aren't tested in CI because the unix and mirage packages require at least OCaml 4.08.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant