Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service.fail_lwt convenience function #229

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Conversation

talex5
Copy link
Contributor

@talex5 talex5 commented Apr 27, 2021

Allows replacing e.g.

Lwt_result.fail (`Capnp (Capnp_rpc.Error.exn "Unknown client %S" name))

with

Service.fail_lwt "Unknown client %S" name

@talex5 talex5 merged commit c42b461 into mirage:master Apr 27, 2021
@talex5 talex5 deleted the error branch April 27, 2021 09:31
talex5 added a commit to talex5/opam-repository that referenced this pull request Apr 27, 2021
…nix and capnp-rpc-lwt (1.1)

CHANGES:

- Update to latest X509, TCP and TLS APIs (@talex5 @hannesm mirage/capnp-rpc#228).

- Add `Service.fail_lwt` convenience function (@talex5 mirage/capnp-rpc#229).

- Remove confusing debug details from `call_for_value_exn` errors (@talex5 mirage/capnp-rpc#230).
  The hidden information is now logged (at debug level) instead.

- Configure TCP keep-alives for incoming connections, not just outgoing ones (@talex5 mirage/capnp-rpc#227).
  This is needed when the client machine crashes without resetting the connection.

- Include version number in opam license field (@talex5 mirage/capnp-rpc#226).
talex5 added a commit to talex5/opam-repository that referenced this pull request Apr 27, 2021
…nix and capnp-rpc-lwt (1.1)

CHANGES:

- Update to latest X509, TCP and TLS APIs (@talex5 @hannesm mirage/capnp-rpc#228).

- Add `Service.fail_lwt` convenience function (@talex5 mirage/capnp-rpc#229).

- Remove confusing debug details from `call_for_value_exn` errors (@talex5 mirage/capnp-rpc#230).
  The hidden information is now logged (at debug level) instead.

- Configure TCP keep-alives for incoming connections, not just outgoing ones (@talex5 mirage/capnp-rpc#227).
  This is needed when the client machine crashes without resetting the connection.

- Include version number in opam license field (@talex5 mirage/capnp-rpc#226).
talex5 added a commit to talex5/opam-repository that referenced this pull request Apr 27, 2021
…nix and capnp-rpc-lwt (1.1)

CHANGES:

- Update to latest X509, TCP and TLS APIs (@talex5 @hannesm mirage/capnp-rpc#228).

- Add `Service.fail_lwt` convenience function (@talex5 mirage/capnp-rpc#229).

- Remove confusing debug details from `call_for_value_exn` errors (@talex5 mirage/capnp-rpc#230).
  The hidden information is now logged (at debug level) instead.

- Configure TCP keep-alives for incoming connections, not just outgoing ones (@talex5 mirage/capnp-rpc#227).
  This is needed when the client machine crashes without resetting the connection.

- Include version number in opam license field (@talex5 mirage/capnp-rpc#226).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant