No SIGPIPE on Windows #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Dec 28, 2020
…pc and capnp-rpc-unix (0.9.0) CHANGES: - Add connection progress indicator (@talex5 mirage/capnp-rpc#220). Clients can now use `Capnp_rpc_unix.with_cap_exn` to show a progress indicator while waiting to connect. It will use the log if enabled. If not, but stderr is a tty, it shows a message while connecting and then erases it (if connecting takes longer than 0.5s). If stderr is not a tty, it just prints a message there. - Use `Mirage_crypto_rng_lwt.initialize` instead of `Mirage_crypto_rng_unix.initialize` (@hannesm mirage/capnp-rpc#217). The former periodically feeds entropy to the RNG, while the latter seeds the RNG only once. - Set TCP_KEEPIDLE=60 if possible (@talex5 mirage/capnp-rpc#214). Cap'n Proto connections tend to be long lived and we therefore turn on the `SO_KEEPALIVE` option. However, the default keepalive timeout of 2 hours is much too long for some networks. In particular, Docker's libnetwork silently drops idle connections after about 10 minutes. Windows support: - Prevent crash if ExtUnix wasn't built with sockopt (@MisterDA mirage/capnp-rpc#218). If ExtUnix isn't built with sockopt then the symbol `have_sockopt_int` isn't available and an exception is raised. This may be the case on some environments (e.g., ExtUnix built with mingw-w64). It is a workaround until support for `TCP_KEEPIDLE` is added for these environments (e.g., using Winsock instead). - There is no SIGPIPE on Windows (@dra27 mirage/capnp-rpc#212). - Switch from "capnpc" to "capnp compile" (@talex5 mirage/capnp-rpc#213). `capnpc` seems to be the old name, and isn't present on Windows. Build changes: - Remove Travis and Dockerfile (@talex5 mirage/capnp-rpc#220). Travis is very slow and error-prone now, and ocaml-ci generates a working Dockerfile automatically for people who want it. - Include transitive dependencies in opam files (@talex5 mirage/capnp-rpc#219). Patch generated by https://github.com/ocurrent/opam-dune-lint/ - Require `tcpip.unix` specifically to get the checksum stubs linked (@hannesm mirage/capnp-rpc#216).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arguably mean of
Sys.set_signalto fail when you ask it to ignore a signal which isn't available, but we are where we are!I haven't checked, but
SIGPIPEshould be available on Cygwin, so it's intentional that this is justSys.win32