Add echo benchmark test #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
reviewed
May 9, 2020
Cjen1
force-pushed
the
benchmark
branch
2 times, most recently
from
428e910
to
3bffb89
Compare
talex5
reviewed
May 10, 2020
There was a problem hiding this comment.
It just needs to be rebased onto master to check it against that.
BTW, I added a couple of suggested changes to make sure the result is correct (looked like it was being ignored before).
I suspect you may get a small speed increase by setting the initial message sizes to sensible values instead of the default, but I don't think we expose that in the API at the moment.
e.g. in capnp-rpc-lwt/request.ml try Message.init_root ~message_size:60 ()
Ensure that the result is as expected. Co-authored-by: Thomas Leonard <[email protected]>
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
May 14, 2020
…pc and capnp-rpc-unix (0.7.0) CHANGES: - Update for x509 0.11.0 API changes (@talex5, mirage/capnp-rpc#196). - Update to new mirage network API (@Cjen1, mirage/capnp-rpc#198). - Add echo benchmark test (@Cjen1, mirage/capnp-rpc#197). - Estimate message sizes to improve performance (@talex5, mirage/capnp-rpc#200). By default, capnproto allocates 8k buffers, but most capnp-rpc messages are much smaller than this. Logging: - Fix application logging, to use library's log (@Cjen1, mirage/capnp-rpc#195). - Expose the endpoint logger (@Cjen1, mirage/capnp-rpc#195). - Only enable debug logging for capnp libraries in the calc example. TLS now generates a lot of messages at debug level (@talex5, mirage/capnp-rpc#200).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a small benchmark for one common use case: accessing a capability over the network (in this case via localhost).
Things to note is that it does not separate the client and server into two separate processes which does impact the performance (since this is a CPU limited benchmark).