Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto pip install #20

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Auto pip install #20

merged 8 commits into from
Jun 19, 2024

Conversation

jiakunw
Copy link
Collaborator

@jiakunw jiakunw commented May 30, 2024

I automated pip install but you have to manually set environmental variable.

@jiakunw
Copy link
Collaborator Author

jiakunw commented May 30, 2024

The code I wrote ran successfully, but the later part did not becasue the cluster did not have cython installed. When I attempted to install cython I got permission errors:
WechatIMG473
WechatIMG470

@jiakunw
Copy link
Collaborator Author

jiakunw commented Jun 2, 2024

This time I added requirement.txt. When I ran python setup.py install I got the following errors:
WechatIMG496
WechatIMG497
I also tried running pip.install mirage but I got some other errors:
WechatIMG498
WechatIMG499
WechatIMG500

@jiazhihao
Copy link
Member

This time I added requirement.txt. When I ran python setup.py install I got the following errors:

Make sure you compile on a GPU node (instead of the catalyst-cluster login node), since there is no GPUs on the login node. You can do so by running salloc --nodes 1 --gres=gpu:1 and then ssh to the assigned node, which should be one of catalyst-0-9 ... catalyst-0-15.

I also tried running pip.install mirage but I got some other errors:

I am not 100% how to resolve this issue.

@jiakunw
Copy link
Collaborator Author

jiakunw commented Jun 5, 2024

I fixed some bugs but _cython is not in mirage
ccc

@jiazhihao
Copy link
Member

The issue is that setup.py does not find mirage/_cython, which is at mirage/python/mirage/_cython. I have pushed a change to setup.py to fix the dir path issue. Can you pull the changes in the main branch and try again?

@jiakunw
Copy link
Collaborator Author

jiakunw commented Jun 7, 2024

I tried running the commands maually using the unmodified verison of setup.py as specified in INSTALL.md, and I got the same error message. Using pdb I realized the error message came from python return cythonize(ret, compiler_directives={"language_level" : 3}) WechatIMG610 could you please take a look at config_cython() ?

@jiakunw
Copy link
Collaborator Author

jiakunw commented Jun 13, 2024

does that mean it worked?
WechatIMG341
I also have some questions about it. cuDNN and CUDA is not available as a Python package on PyPI. cuDNN is a GPU-accelerated library for deep neural networks provided by NVIDIA, and it should be installed via conda or directly from NVIDIA's website, not from PyPI. So I removed cuda and cudnn version from requirements.txt, but they are both installed, and it seemed working. Does that mean it's done or I should fix them??

@jiazhihao
Copy link
Member

@jiakunw Thanks for the PR. One quick comment: you may not want to include your personal vscode config in this PR: vscode/sftp.json.

@jiakunw
Copy link
Collaborator Author

jiakunw commented Jun 18, 2024

fixed!

@jiazhihao
Copy link
Member

The PR looks great overall. One last thing: you can use git rm to remove the sftp.json file and run script/format.sh to auto-format your changes.

@jiakunw
Copy link
Collaborator Author

jiakunw commented Jun 19, 2024

script/format.sh

scripts/format.sh: line 72: /Users/jackiexu/Development/mirage/.tools/clang-format-15-master-1d7ec53d: cannot execute binary file: Exec format error``` I got this error when I ran it

@jiazhihao
Copy link
Member

I can correct format in another PR. Can you use git rm to remove your json file from this PR.

@jiakunw
Copy link
Collaborator Author

jiakunw commented Jun 19, 2024

I removed it yesterday and there was no json file in the repo
WechatIMG58
WechatIMG59

@jiazhihao
Copy link
Member

It is still there in this PR: https://github.com/mirage-project/mirage/pull/20/files. Let me push a fix to address this issue.

@jiakunw
Copy link
Collaborator Author

jiakunw commented Jun 19, 2024

I re-removed it, it should be good for now :)

@jiazhihao jiazhihao merged commit ff7f9d6 into main Jun 19, 2024
@jiazhihao
Copy link
Member

merged. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants