Visualizer Ver1.0 #113
Merged
Visualizer Ver1.0 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the casting issues between Cython and Python objects
jiazhihao
reviewed
Oct 22, 2024
deps/cutlass
Outdated
There was a problem hiding this comment.
We may want to update your cutlass commit. You can run git submodule update to update it.
There was a problem hiding this comment.
I have checkouted cutlass submodule to commit cc3c29a
jiazhihao
requested changes
Oct 22, 2024
| @@ -464,6 +833,32 @@ cdef class CyTBGraph: | |||
| t = ctypes.cast(<unsigned long long>ptr, ctypes.c_void_p) | |||
| return STensor(t) | |||
|
|
|||
| property grid_dim: | |||
There was a problem hiding this comment.
I was wondering if we can unify grid_dim and block_dim here. For example, both of them can return a dictionary or a tuple. Let's try not to use list.
There was a problem hiding this comment.
It seems like block_dim is not used in the graph shown in the paper and actually also not used in the graph visualizer generated🤔. I removed it in current version.
added 2 commits
October 25, 2024 21:59
… in func and remove block_dim
jiazhihao
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Embedded visualizer in python interface.
Simply use
graph.visualize("graph_name", "file_name")to generate the graph.Will support the newly added output node.
Related Issues:
Linked Issues:
Issues closed by this PR: