Mutual exclusion for file writes #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🐋 🤖 A docker image for this PR has been built! docker pull freyrcli/freyrjs-git:pr-338
What's this?This docker image is a self-contained sandbox that includes all the patches made in this PR. Allowing others to easily use your patches without waiting for it to get merged and released officially. For more context, see https://github.com/miraclx/freyr-js#docker-development. |
miraclx
force-pushed
the
single_write_events
branch
from
439acd8 to
da2fdc3
Compare
miraclx
force-pushed
the
master
branch
2 times, most recently
from
a64d984 to
c113e07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could be the case that a playlist, or an artist with two identical albums have identical tracks. Freyr, resolving them to the same source, ends up downloading the track to the same cache stage, encoding and writing it out to the same output file.
Lots of potential for clashes, and race conditions. At the end of the day, the file may end up corrupt.
It's a game of russian roulette, basically.
This patch makes it so, a file is only ever touched by freyr once in the entire lifetime of the program's execution.
So if a track is being downloaded by being on another album, that download task carries through for the whole program.
And if they're writing to the same file, well, only one gets to do the writing.