Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: resolve interdependencies #273

Merged
merged 2 commits into from
Jul 16, 2022
Merged

docker: resolve interdependencies #273

merged 2 commits into from
Jul 16, 2022

Conversation

miraclx
Copy link
Owner

@miraclx miraclx commented Jul 16, 2022

Try as much as possible to let undepending steps build independently of each other.

Helps take maximum advantage of the build cache.

And apparently final image size, so this contributes to #257

@github-actions
Copy link

github-actions bot commented Jul 16, 2022


🐋 🤖

A docker image for this PR has been built!

docker pull freyrcli/freyrjs-git:pr-273
Latest Master
This Patch

What's this?

This docker image is a self-contained sandbox that includes all the patches made in this PR. Allowing others to easily use your patches without waiting for it to get merged and released officially.

For more context, see https://github.com/miraclx/freyr-js#docker-development.

@miraclx miraclx mentioned this pull request Jul 16, 2022
@miraclx miraclx merged commit b7e2094 into master Jul 16, 2022
@miraclx miraclx deleted the refactor-dockerfile branch July 16, 2022 02:47
@miraclx miraclx mentioned this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant