Adding loader for SCMS #597
Conversation
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
==========================================
+ Coverage 96.96% 97.07% +0.10%
==========================================
Files 58 61 +3
Lines 6990 7238 +248
==========================================
+ Hits 6778 7026 +248
Misses 212 212 |
genisplaja
force-pushed
the
genis/scms
branch
from
cbd8644
to
12d7c83
Compare
There was a problem hiding this comment.
Hey @genisplaja, looks great, left just minor comments. Let me know your thoughts and we can merge soon!
mirdata/datasets/scms.py
Outdated
| return load_audio(*args, **kwargs) | ||
|
|
||
| def load_pitch(self, *args, **kwargs): | ||
| return load_pitch(*args, **kwargs) |
There was a problem hiding this comment.
Same here, is this the issue we discussed today that appears in most loaders?
There was a problem hiding this comment.
missed testing load_audio actually (done it now), but load_pitch and load_activations are actually tested, so I wonder if yeah, is one of these testing problems we discussed...
There was a problem hiding this comment.
ok sorry @magdalenafuentes, these functions should not be there, were deprecated a few versions ago. The newest loaders do not have them actually, started from the wrong template hehe. Fixed!
Adding loader for SCMS (Saraga Carnatic Melody Synth)
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/, e.g.make_my_dataset_index.py, which generates an index file.mirdata/indexes/e.g.my_dataset_index.json.mirdata/my_dataset.pytests/datasets/, e.g.test_my_dataset.pydocs/source/mirdata.rstanddocs/source/table.rsttests/test_full_dataset.pyon your dataset.