-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding loader for CompMusic Carnatic Varnam #579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into genis/carnatic_varnam
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 96.88% 96.96% +0.07%
==========================================
Files 57 58 +1
Lines 6816 6990 +174
==========================================
+ Hits 6604 6778 +174
Misses 212 212 |
genisplaja
changed the title
[WIP] Adding loader for CompMusic Carnatic Varnam
Adding loader for CompMusic Carnatic Varnam
Mar 14, 2023
harshpalan
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @genisplaja, this looks good. I'll approve it. Please go ahead and merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding loader for CompMusic Carnatic Varnam
This one has been pending for so long, so it's nice that we got it finally here!
Description
Please include the following information at the top level docstring for the dataset's module mydataset.py:
Dataset loaders checklist:
scripts/
, e.g.make_my_dataset_index.py
, which generates an index file.mirdata/indexes/
e.g.my_dataset_index.json
. This is done but we will have to re-run it when we have the new canonical (and fixed) version of the dataset.mirdata/my_dataset.py
tests/datasets/
, e.g.test_my_dataset.py
docs/source/mirdata.rst
anddocs/source/table.rst
tests/test_full_dataset.py
on your dataset.Loader made possible thanks to @adithishankar19's help :)