Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version of CompMusic Turkish Makam Dataset #576

Merged
merged 20 commits into from
Nov 2, 2023
Merged

New version of CompMusic Turkish Makam Dataset #576

merged 20 commits into from
Nov 2, 2023

Conversation

genisplaja
Copy link
Collaborator

Addresses #551

@guillemcortes guillemcortes mentioned this pull request Feb 24, 2023
Closed
15 tasks
@dagett dagett mentioned this pull request Feb 25, 2023
Closed
@codecov
Copy link

codecov bot commented Mar 8, 2023 •
edited
Loading

Codecov Report

Merging #576 (a0897e8) into master (496eb4a) will increase coverage by 0.04%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   96.96%   97.01%   +0.04%     
==========================================
  Files          58       58              
  Lines        6990     6990              
==========================================
+ Hits         6778     6781       +3     
+ Misses        212      209       -3

@guillemcortes guillemcortes self-requested a review October 30, 2023 16:27
@guillemcortes guillemcortes added the broken link The dataset is currently not accessible for download label Oct 31, 2023
guillemcortes
guillemcortes requested changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@guillemcortes guillemcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor changes :)

tests/datasets/test_otmm_makam.py Outdated Show resolved Hide resolved
tests/datasets/test_otmm_makam.py Outdated Show resolved Hide resolved
scripts/make_compmusic_otmm_makam_index.py Outdated Show resolved Hide resolved
guillemcortes
guillemcortes approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@guillemcortes guillemcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Ready to merge

@guillemcortes guillemcortes merged commit ef72b2c into master Nov 2, 2023
10 checks passed
@guillemcortes guillemcortes deleted the genis/fix_makam branch November 1, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillemcortes guillemcortes guillemcortes approved these changes

Assignees
No one assigned
Labels
broken link The dataset is currently not accessible for download
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@genisplaja @guillemcortes @harshpalan