Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding loader for Filosax #536

Merged
merged 42 commits into from
Oct 4, 2022
Merged
Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
682c33f
Added filosax.py
dave-foster Oct 26, 2021
8925224
Added filosax.py and index
dave-foster Oct 27, 2021
5187a2f
Fixed load audio bugs
dave-foster Oct 27, 2021
e00c62d
Added note annotations
dave-foster Oct 27, 2021
ebc6556
Added test resources
dave-foster Oct 28, 2021
b05e446
Added test index
dave-foster Oct 28, 2021
996ca9b
Added test_filosax.py
dave-foster Oct 29, 2021
f767cbe
Final tweaks ahead of PR
dave-foster Nov 3, 2021
dafd7f4
Fixing null/None in indexes
dave-foster Nov 3, 2021
addee46
Black code formatting
dave-foster Nov 4, 2021
75f0d0e
Fixing failed tests
dave-foster Nov 4, 2021
c285236
More fixes
dave-foster Nov 4, 2021
f25842a
Fixed to_jams method
dave-foster Nov 4, 2021
2c1a0ff
Fixed exceptions and return types
dave-foster Nov 4, 2021
3748a05
More corrections
dave-foster Nov 4, 2021
96d6ea0
Another attempt to fix Exception error
dave-foster Nov 4, 2021
f3b82d1
Still on the exception thing
dave-foster Nov 4, 2021
ae107d6
Update Filosax (full) to v1.0
dave-foster Jan 19, 2022
a0c0d6f
Code formatting fix
dave-foster Jan 19, 2022
7260557
Re-commit
dave-foster Jul 18, 2022
37f4ad1
Merge branch 'mir-dataset-loaders:master' into filosax
dave-foster Jul 22, 2022
4413e36
Update filosax.py
dave-foster Aug 7, 2022
bcf53c3
Merge branch 'filosax' of https://github.com/dave-foster/mirdata into…
dave-foster Aug 7, 2022
9f9da6c
Implementing Marius's suggestion
dave-foster Aug 8, 2022
0827351
Formatting fix
dave-foster Aug 8, 2022
326a1df
Still trying
dave-foster Aug 8, 2022
abad330
Trying dummy Note
dave-foster Aug 8, 2022
6a072a3
Another dummy Note attempt
dave-foster Aug 8, 2022
71456a5
@dave-foster Another dummy Note attempt
dave-foster Aug 8, 2022
5cb0797
Another dummy Note attempt v3
dave-foster Aug 8, 2022
b1ba41c
Formatting
dave-foster Aug 8, 2022
2e3ab18
Trying @genisplaja's suggestions
dave-foster Aug 9, 2022
4fd3d42
Bug fixes
dave-foster Aug 9, 2022
9f0a522
Adding tests to test_metadata for coverage
dave-foster Aug 10, 2022
bed6d1a
Fix error in test for sax track names
dave-foster Aug 10, 2022
c406540
Revert re-format attempt
dave-foster Aug 10, 2022
99c0ee7
Formatting review
dave-foster Sep 26, 2022
4c86e6a
Merge branch 'master' into filosax
dave-foster Sep 26, 2022
09bc3b8
Correcting formatting fail
dave-foster Sep 26, 2022
1a7d420
Conforming to review
dave-foster Sep 28, 2022
04b3b16
Fix new empty [Note] test
dave-foster Sep 28, 2022
6ec3ef1
Remove extra )!
dave-foster Sep 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/source/mirdata.rst
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ da_tacos
:inherited-members:


filosax
^^^^^^^

.. automodule:: mirdata.datasets.filosax
:members:
:inherited-members:


freesound_one_shot_percussive_sounds
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down
12 changes: 12 additions & 0 deletions docs/source/table.rst
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,18 @@
- .. image:: https://licensebuttons.net/l/by-sa/4.0/80x15.png
:target: https://creativecommons.org/licenses/by-sa/4.0

* - Filosax
- - audio: 🔑
- annotations: 🔑
- midi: 🔑
- - :ref:`f0`
- :ref:`beats`
- :ref:`chords`
- :ref:`tempo`
- :ref:`notes`
- 48
- ❌

* - Freesound One-Shot Percussive Sounds
- - audio: ✅
- annotations: ✅
Expand Down
512 changes: 512 additions & 0 deletions mirdata/datasets/filosax.py

Large diffs are not rendered by default.

Loading