fix cancelled download bug #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 30 30
Lines 2934 2934
=======================================
Hits 2878 2878
Misses 56 56 |
nkundiushuti
requested changes
Nov 24, 2020
There was a problem hiding this comment.
so when you do download with force_overwrite=True the download works. this solution is for the default case force_overwrite=False when the download is failing for some reason.
could we also display a message when the checksum for the archives do not match so that the users try to download the dataset with force_overwrite=True?
nkundiushuti
approved these changes
Dec 1, 2020
|
ok done! |
magdalenafuentes
approved these changes
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I said on #326
When it is downloading a remote zip if I cancel it (^C) (or internet breaks down) and I come back to download the remote a sha related error shows up :S. This is because the corrupt .zip (half-downloaded) is not removed