TinySOL #165

lostanlen · 2020-02-01T22:24:42Z

TinySOL is a dataset of 2478 samples, each containing a single musical note from one of 14 different instruments:

    Bass Tuba
    French Horn
    Trombone
    Trumpet in C
    Accordion
    Contrabass
    Violin
    Viola
    Violoncello
    Bassoon
    Clarinet in B-flat
    Flute
    Oboe
    Alto Saxophone

These sounds were originally recorded at Ircam in Paris (France) between 1996
and 1999, as part of a larger project named Studio On Line (SOL). Although SOL
contains many combinations of mutes and extended playing techniques, TinySOL
purely consists of sounds played in the so-called "ordinary" style, and in
absence of mute.

TinySOL can be used for education and research purposes. In particular, it can
be employed as a dataset for training and/or evaluating music information
retrieval (MIR) systems, for tasks such as instrument recognition or
fundamental frequency estimation. For this purpose, we provide an official 5-
fold split of TinySOL. This split has been carefully balanced in terms of
instrumentation, pitch range, and dynamics. For the sake of research
reproducibility, we encourage users of TinySOL to adopt this split and report
their results in terms of average performance across folds.

(this PR is part of an under-review paper to ICMC)
(second take on #164 after a mishap of running the TinySOL style checker)

codecov · 2020-02-01T22:27:12Z

Codecov Report

Merging #165 into master will increase coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   98.29%   98.44%   +0.15%     
==========================================
  Files          17       18       +1     
  Lines        1761     1934     +173     
==========================================
+ Hits         1731     1904     +173     
  Misses         30       30

lostanlen · 2020-02-01T22:27:44Z

The build passes and the style checker ("black") passes too. Will now write unit tests and then ask for a CR.

create tinysol_index.json start writing tinysol.py write cite for TinySOL write tinysol docstring update tinysol parser update tinysol pretty-print update tinysol metadata_path write tinysol.download add Zenodo urls and checksums to tinysol add tinysol to mirdata __init__ set tinysol to v3.0 syntax error in tinysol update make_tinysol_index re-generate TinySOL index for v3.0 bugfix ANNOTATION_REMOTE in tinysol run black -S on TinySOL PR upload TinySOL testing resources TinySOL test_cite TinySOL test_validate TinySOL test_download TinySOL test_load TinySOL test_track_ids TinySOL test_to_jams update TinySOL_metadata update TinySOL metadata indexing system remove WAV extension from TinySOL index bugfix tinysol module path descriptions and string-int conversion update make_tinysol_index with splitext keys run black style checker on TinySOL update tinysol test convert fold to int convert Resampled field to bool test tinysol with a string instrument for higher coverage remove trailing comma in repr_string for tinysol (wind instrument) write more TinySOL tests bugfix tinysol bool conversion bugfix tinysol tests add Cb-ord-A2-mf-3cR to TinySOL metadata in tests run black style checker on TinySOL

lostanlen · 2020-02-08T01:53:53Z

Unit tests are passing. I squashed the PR to a single commit. The coverage is 100% on the tinysol module.
I think that this is ready for CR.

lostanlen · 2020-02-08T04:00:32Z

usability tests are passing too now 🎉

rabitt

New loader checklist:

Create a script in scripts/, e.g. make_my_dataset_index.py
Run the script on the canonical version of the dataset and save the index in mirdata/indexes/ e.g. my_dataset_index.json
Create a module in mirdata, e.g. mirdata/my_dataset.py
Create tests in tests/, e.g. test_my_dataset.py
Add the module to docs/source/mirdata.rst
Add the module to mirdata/__init__.py

This is nearly perfect! Just add TinySOL to docs/source/mirdata.rst, and decide if you want to include the data split as additional metadata (see my comment). Otherwise it's good to go!

mirdata/tinysol.py

lostanlen · 2020-02-24T03:55:48Z

This is nearly perfect! Just add TinySOL to docs/source/mirdata.rst, and decide if you want to include the data split as additional metadata (see my comment)

@rabitt thank you. i switched to TinySOL v5 (hopefully the definitive version of TinySOL!) and did both of the changes your requested.

lostanlen · 2020-02-24T04:21:55Z

i made a quick usability test and everything works as intended.

magdalenafuentes · 2020-03-04T17:20:19Z

@rabitt should we merge this one too?

rabitt

Looks great!

New loader checklist:

Create a script in scripts/, e.g. make_my_dataset_index.py
Run the script on the canonical version of the dataset and save the index in mirdata/indexes/ e.g. my_dataset_index.json
Create a module in mirdata, e.g. mirdata/my_dataset.py
Create tests in tests/, e.g. test_my_dataset.py
Add the module to docs/source/mirdata.rst
Add the module to mirdata/__init__.py

rabitt · 2020-03-04T21:29:52Z

@lostanlen feel free to merge after updating the version in setup.py

lostanlen · 2020-03-06T00:41:18Z

conflicts resolved. merging

TinySOL (#165) this PR adds TinySOL as a new loader create tinysol_index.json start writing tinysol.py write cite for TinySOL write tinysol docstring update tinysol parser update tinysol pretty-print update tinysol metadata_path write tinysol.download add Zenodo urls and checksums to tinysol add tinysol to mirdata __init__ set tinysol to v3.0 syntax error in tinysol update make_tinysol_index re-generate TinySOL index for v3.0 bugfix ANNOTATION_REMOTE in tinysol run black -S on TinySOL PR upload TinySOL testing resources TinySOL test_cite TinySOL test_validate TinySOL test_download TinySOL test_load TinySOL test_track_ids TinySOL test_to_jams update TinySOL_metadata update TinySOL metadata indexing system remove WAV extension from TinySOL index bugfix tinysol module path descriptions and string-int conversion update make_tinysol_index with splitext keys run black style checker on TinySOL update tinysol test convert fold to int convert Resampled field to bool test tinysol with a string instrument for higher coverage remove trailing comma in repr_string for tinysol (wind instrument) write more TinySOL tests bugfix tinysol bool conversion bugfix tinysol tests add Cb-ord-A2-mf-3cR to TinySOL metadata in tests run black style checker on TinySOL * update to TinySOL v4.0 * run black on tinysol.py * upgrade tinysol to v5.0 * update tinysol tests * bugfix tinysol _load_metadata * update tinysol index (v5) * bugfix _load_metadata in tinysol * bugfix self.audio_path in tinysol * update tinysol tests * bugfix _load_metadata in tinysol * bis * ter * run black -S . on tinysol.py * add tinysol to docs/mirdata.rst * improve tinysol docstring [ci skip] * bugfix ANNOTATION_REMOTE in tinysol * update tinysol remotes (v6)

lostanlen mentioned this pull request Feb 8, 2020

[WIP] TinySOL #164

Closed

lostanlen changed the title ~~[WIP] TinySOL (take 2)~~ TinySOL Feb 8, 2020

lostanlen requested a review from magdalenafuentes February 8, 2020 01:55

Vincent Lostanlen added 2 commits February 7, 2020 22:53

update to TinySOL v4.0

55c1479

run black on tinysol.py

5c01c3b

rabitt requested changes Feb 21, 2020

View reviewed changes

mirdata/tinysol.py Show resolved Hide resolved

Vincent Lostanlen added 13 commits February 23, 2020 21:04

upgrade tinysol to v5.0

62f049f

update tinysol tests

1e987be

bugfix tinysol _load_metadata

5c284f2

update tinysol index (v5)

3493761

bugfix _load_metadata in tinysol

81a881c

bugfix self.audio_path in tinysol

17e3b1b

update tinysol tests

2c0bb8c

bugfix _load_metadata in tinysol

658e9f2

bis

2f73933

ter

e1fc534

run black -S . on tinysol.py

1ce683a

add tinysol to docs/mirdata.rst

51c0527

improve tinysol docstring [ci skip]

4d2e968

Vincent Lostanlen added 2 commits February 23, 2020 23:03

bugfix ANNOTATION_REMOTE in tinysol

0c3c4a0

update tinysol remotes (v6)

d5c8bb9

lostanlen requested a review from rabitt February 24, 2020 04:22

lostanlen mentioned this pull request Feb 24, 2020

[WIP] OrchideaSOL #174

Closed

rabitt approved these changes Mar 4, 2020

View reviewed changes

Merge branch 'master' into sol-v2

3e7c6d4

lostanlen merged commit 695187c into mir-dataset-loaders:master Mar 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TinySOL #165

TinySOL #165

lostanlen commented Feb 1, 2020 •

edited

Loading

codecov bot commented Feb 1, 2020 •

edited

Loading

lostanlen commented Feb 1, 2020

lostanlen commented Feb 8, 2020 •

edited

Loading

lostanlen commented Feb 8, 2020

rabitt left a comment •

edited by lostanlen

Loading

lostanlen commented Feb 24, 2020

lostanlen commented Feb 24, 2020

magdalenafuentes commented Mar 4, 2020

rabitt left a comment

rabitt commented Mar 4, 2020

lostanlen commented Mar 6, 2020

TinySOL #165

TinySOL #165

Conversation

lostanlen commented Feb 1, 2020 • edited Loading

codecov bot commented Feb 1, 2020 • edited Loading

Codecov Report

lostanlen commented Feb 1, 2020

lostanlen commented Feb 8, 2020 • edited Loading

lostanlen commented Feb 8, 2020

rabitt left a comment • edited by lostanlen Loading

Choose a reason for hiding this comment

lostanlen commented Feb 24, 2020

lostanlen commented Feb 24, 2020

magdalenafuentes commented Mar 4, 2020

rabitt left a comment

Choose a reason for hiding this comment

rabitt commented Mar 4, 2020

lostanlen commented Mar 6, 2020

lostanlen commented Feb 1, 2020 •

edited

Loading

codecov bot commented Feb 1, 2020 •

edited

Loading

lostanlen commented Feb 8, 2020 •

edited

Loading

rabitt left a comment •

edited by lostanlen

Loading