Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

medleydb_melody melody3 type not in mir_eval format #101

Closed
rabitt opened this issue Aug 2, 2019 · 2 comments · Fixed by #182
Closed

medleydb_melody melody3 type not in mir_eval format #101

rabitt opened this issue Aug 2, 2019 · 2 comments · Fixed by #182
Assignees
@rabitt
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@rabitt
Copy link
Collaborator

rabitt commented Aug 2, 2019

mir_eval expects a ragged array for multipitch outputs, but melody3 data in mirdata is a numpy array.
@magdalenafuentes
Copy link
Collaborator

sections are given now as a SectionData object, with start_times, end_times, and sections attributes. mir_eval expects an array of intervals (which means concatenate start_times and end_times) and an array with sections.

Should we modify the SectionData object accordingly? Also: when playing around with that found
issues in the annotations such as intervals of length 0 or timestamps bigger than track duration :/ thoughts?

@rabitt rabitt added the bug Something isn't working label Sep 13, 2019
@rabitt
Copy link
Collaborator Author

rabitt commented Sep 13, 2019

@magdalenafuentes can you open a separate issue about the sections?

@rabitt rabitt added this to the 0.1.0 First Stable Release milestone Nov 2, 2019
@rabitt rabitt self-assigned this Nov 2, 2019
@rabitt rabitt removed this from the 0.1.0 First Stable Release milestone Nov 4, 2019
@rabitt rabitt added this to the 0.2.0 milestone Dec 6, 2019
rabitt pushed a commit that referenced this issue Mar 5, 2020
fixes #101
ec23cf7
@rabitt rabitt mentioned this issue Mar 5, 2020
Merged
lostanlen pushed a commit that referenced this issue Mar 6, 2020
[MRG] Add MultipitchData (#182)
1baecfb 
* fixes #101

* run black
nkundiushuti pushed a commit that referenced this issue Nov 4, 2020
1b0b0ac 
 
[MRG] Add MultipitchData (#182)

* fixes #101

* run black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rabitt rabitt

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

[MRG] Add MultipitchData mir-dataset-loaders/mirdata
2 participants
@rabitt @magdalenafuentes