Skip to content

Commit

Permalink
Adding loader for Filosax (#536)
Browse files Browse the repository at this point in the history
* Added filosax.py

* Added filosax.py and index

* Fixed load audio bugs

* Added note annotations

* Added test resources

* Added test index

* Added test_filosax.py

* Final tweaks ahead of PR

* Fixing null/None in indexes

* Black code formatting

* Fixing failed tests

* More fixes

* Fixed to_jams method

* Fixed exceptions and return types

* More corrections

* Another attempt to fix Exception error

* Still on the exception thing

* Update Filosax (full) to v1.0

* Code formatting fix

* Re-commit

Checking CircleCI errors

* Update filosax.py

Trying Marius's suggestion for fixing exception error

* Implementing Marius's suggestion

* Formatting fix

* Still trying

* Trying dummy Note

* Another dummy Note attempt

* @dave-foster Another dummy Note attempt

* Another dummy Note attempt v3

* Formatting

* Trying @genisplaja's suggestions

* Bug fixes

* Adding tests to test_metadata for coverage

* Fix error in test for sax track names

* Revert re-format attempt

* Formatting review

* Correcting formatting fail

* Conforming to review

* Fix new empty [Note] test

* Remove extra )!
  • Loading branch information
dave-foster authored Oct 4, 2022
1 parent 8db5795 commit 8c785b6
Show file tree
Hide file tree
Showing 24 changed files with 16,004 additions and 0 deletions.
8 changes: 8 additions & 0 deletions docs/source/mirdata.rst
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ da_tacos
:inherited-members:


filosax
^^^^^^^

.. automodule:: mirdata.datasets.filosax
:members:
:inherited-members:


freesound_one_shot_percussive_sounds
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down
12 changes: 12 additions & 0 deletions docs/source/table.rst
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,18 @@
- .. image:: https://licensebuttons.net/l/by-sa/4.0/80x15.png
:target: https://creativecommons.org/licenses/by-sa/4.0

* - Filosax
- - audio: 🔑
- annotations: 🔑
- midi: 🔑
- - :ref:`f0`
- :ref:`beats`
- :ref:`chords`
- :ref:`tempo`
- :ref:`notes`
- 48
- ❌

* - Freesound One-Shot Percussive Sounds
- - audio: ✅
- annotations: ✅
Expand Down
510 changes: 510 additions & 0 deletions mirdata/datasets/filosax.py

Large diffs are not rendered by default.

Loading

0 comments on commit 8c785b6

Please sign in to comment.