Fix error on clone settings without organization selected

[Donnype]

Changes

Remove unused endpoint and set object list field when bypassing the ListView.get() because the form was invalid. Formviews on a POST call the form_invalid() which calls self.render_to_response(self.get_context(form=form)) immediately. But at this time the (Base)ListView has not set self.object_list = self.get_queryset() since it only does this on a GET request. But get_context_data()' _is_ being called on a generic (list?) view that tries to set context["object_list"] = self.object_list`, which fails because it does not have that property.

Issue link

Fixes #996

Proof

---

Code Checklist

• All the commits in this PR are properly PGP-signed and verified;
• This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
• I have written unit tests for the changes or fixes I made.
• For any non-trivial functionality, I have added integration and/or end-to-end tests.
• I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

• I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
• I have made corresponding changes to the documentation, if necessary.

---

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

---

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

[ammar92]

I think it's something else that caused this not to work as a ListView object with a custom query set. But the code seems valid and ListViews without Django ORM models are always a bit tricky.

[Donnype]

@ammar92 I added a more detailed description of the flow going wrong, perhaps that clears things up?

[Darwinkel]

Checklist for QA:

• I have checked out this branch, and successfully ran a fresh make reset.
• I confirmed that there are no unintended functional regressions in this branch:
  • I have managed to pass the onboarding flow
  • Objects and Findings are created properly
  • Tasks are created and completed properly
• I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

• An organization must always be specified now
• Cloning and editing Katalogus / boefje settings still work

What doesn't work:

• Curiously (possibly an existing bug), the clone page is incomplete in which settings it displays. I tested a bit, and it looks like the settings page only displays the most recently added setting for each boefje. In the below screenshots, I removed and re-added the PROTOCOL setting for nmap, and it replaces TOP_PORTS. Cloning does seem to apply all settings correctly - this is presumably a visual bug.
  
  
  

[Donnype]

@Darwinkel Good spot, fixed!

[Darwinkel]

@Darwinkel Good spot, fixed!

Fix confirmed, ready to merge :)

[underdarknl]

Is novalidate hier nuttig op? Die skipped namelijk ook de required fields daarmee.

[ammar92]

Somehow I still think we're misusing the ListView. It is supposed to always render a list of objects regardless of the form's validity. If our use case or flow is different in some way, then indeed we shouldn't use it as such.