Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docker-py #985

Merged
merged 1 commit into from
May 16, 2023
Merged

Updated docker-py #985

merged 1 commit into from
May 16, 2023

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented May 16, 2023

Changes

Version bumped docker-py due to recent updates in urllib3 and requests.

Issue link

Solves #984

Proof

Services start and I was able to start plugins and see findings.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@ammar92 ammar92 added bug Something isn't working dependencies Pull requests that update a dependency file labels May 16, 2023
@ammar92 ammar92 marked this pull request as ready for review May 16, 2023 13:08
@ammar92 ammar92 requested a review from a team as a code owner May 16, 2023 13:08
@dekkers dekkers merged commit 3973468 into main May 16, 2023
@dekkers dekkers deleted the fix/update-docker-py branch May 16, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants