Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint rerun bits #899

Merged
merged 12 commits into from
May 10, 2023
Merged

Endpoint rerun bits #899

merged 12 commits into from
May 10, 2023

Conversation

noamblitz
Copy link
Contributor

@noamblitz noamblitz commented May 2, 2023

Changes

Add an endpoint to recalculate all bits in an organization. Add permission recalculate_bits which is assigned to admins.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@noamblitz noamblitz requested a review from a team as a code owner May 2, 2023 13:48
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

File Coverage
All files 65%
bits/definitions.py 65%
bits/runner.py 56%
bits/https_availability/https_availability.py 93%
bits/oois_in_headers/oois_in_headers.py 57%
bits/spf_discovery/internetnl_spf_parser.py 55%
bits/spf_discovery/spf_discovery.py 72%
octopoes/api/api.py 58%
octopoes/api/models.py 75%
octopoes/api/router.py 46%
octopoes/core/app.py 80%
octopoes/core/service.py 44%
octopoes/events/events.py 96%
octopoes/events/manager.py 65%
octopoes/models/__init__.py 86%
octopoes/models/datetime.py 66%
octopoes/models/exception.py 83%
octopoes/models/origin.py 70%
octopoes/models/path.py 99%
octopoes/models/types.py 95%
octopoes/models/ooi/certificate.py 96%
octopoes/models/ooi/config.py 89%
octopoes/models/ooi/email_security.py 95%
octopoes/models/ooi/findings.py 94%
octopoes/models/ooi/network.py 97%
octopoes/models/ooi/service.py 91%
octopoes/models/ooi/software.py 71%
octopoes/models/ooi/web.py 81%
octopoes/models/ooi/dns/records.py 95%
octopoes/models/ooi/dns/zone.py 77%
octopoes/repositories/ooi_repository.py 39%
octopoes/repositories/origin_parameter_repository.py 53%
octopoes/repositories/origin_repository.py 52%
octopoes/repositories/scan_profile_repository.py 45%
octopoes/xtdb/client.py 49%
octopoes/xtdb/query_builder.py 69%
octopoes/xtdb/related_field_generator.py 71%
tests/conftest.py 88%
tests/integration/test_xtdb_client.py 34%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 8e04111

Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff

rocky/rocky/views/organization_settings.py Show resolved Hide resolved
octopoes/octopoes/api/router.py Outdated Show resolved Hide resolved
rocky/rocky/views/organization_settings.py Show resolved Hide resolved
octopoes/octopoes/api/router.py Outdated Show resolved Hide resolved
rocky/tools/management/commands/setup_dev_account.py Outdated Show resolved Hide resolved
@noamblitz noamblitz requested a review from dekkers May 9, 2023 12:32
octopoes/octopoes/connector/octopoes.py Outdated Show resolved Hide resolved
@praseodym praseodym added this to the OpenKAT v1.8 milestone May 10, 2023
@Donnype
Copy link
Contributor

Donnype commented May 10, 2023

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make kat.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended:

What works:

  • The endpoints are triggered and handled, displaying the right message:
    image

Succesful call in the Octopoes logs:
image

What doesn't work:

  • I found this bug in the logs triggering the endpoint, not sure if it is (an older) issue or some weird hostnames found on my website?

image

Bug or feature?:

  • I am not sure the organization settings page is the most intuitive place for this button for me, but I'll leave that up to you and/or the frontend team!

@dekkers dekkers merged commit bc6867e into main May 10, 2023
@dekkers dekkers deleted the endpoint-rerun-bits branch May 10, 2023 15:54
praseodym pushed a commit to praseodym/kat that referenced this pull request May 15, 2023
Co-authored-by: Jesse Lisser <[email protected]>
Co-authored-by: ammar92 <[email protected]>
Co-authored-by: Donny Peeters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants