Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated linter configs #817

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Updated linter configs #817

merged 7 commits into from
Apr 26, 2023

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented Apr 26, 2023

Changes

Enabled and fixed these ruff plugins:

  • G
  • INP
  • T20

More to enable and fix soon.

Issue link

#784


Code Checklist

  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

File Coverage
All files 65%
bits/definitions.py 64%
bits/runner.py 56%
bits/https_availability/https_availability.py 93%
bits/oois_in_headers/oois_in_headers.py 57%
bits/spf_discovery/internetnl_spf_parser.py 55%
bits/spf_discovery/spf_discovery.py 72%
octopoes/api/api.py 59%
octopoes/api/models.py 75%
octopoes/api/router.py 52%
octopoes/core/app.py 69%
octopoes/core/service.py 46%
octopoes/events/events.py 96%
octopoes/events/manager.py 65%
octopoes/models/__init__.py 86%
octopoes/models/datetime.py 66%
octopoes/models/exception.py 83%
octopoes/models/origin.py 70%
octopoes/models/path.py 99%
octopoes/models/types.py 95%
octopoes/models/ooi/certificate.py 96%
octopoes/models/ooi/email_security.py 95%
octopoes/models/ooi/findings.py 94%
octopoes/models/ooi/network.py 97%
octopoes/models/ooi/service.py 91%
octopoes/models/ooi/software.py 71%
octopoes/models/ooi/web.py 81%
octopoes/models/ooi/dns/records.py 95%
octopoes/models/ooi/dns/zone.py 77%
octopoes/repositories/ooi_repository.py 40%
octopoes/repositories/origin_parameter_repository.py 53%
octopoes/repositories/origin_repository.py 53%
octopoes/repositories/scan_profile_repository.py 45%
octopoes/xtdb/client.py 39%
octopoes/xtdb/query_builder.py 69%
octopoes/xtdb/related_field_generator.py 73%
tests/conftest.py 91%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against e656cbd

# Conflicts:
#	rocky/tests/katalogus/test_katalogus_plugin_detail.py
@praseodym
Copy link
Contributor

praseodym commented Apr 26, 2023

For reviewers like me that don't know those abbreviations by heart: a list of Ruff rules can be found at https://beta.ruff.rs/docs/rules/ 🙂

@ammar92 ammar92 marked this pull request as ready for review April 26, 2023 13:33
@ammar92 ammar92 requested a review from a team as a code owner April 26, 2023 13:33
@ammar92 ammar92 merged commit c76c110 into main Apr 26, 2023
@ammar92 ammar92 deleted the fix/linter-configs branch April 26, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants